[SOLR-8778] Deprecate CSVStrategy's setters, and make its pre-configured strategies immutable

• Type: Bug
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Fix Version/s: 6.0
• Assignee: Steven Rowe
• Reporter: Steven Rowe
• Created: 03/Mar/16 00:00
• Updated: 24/Feb/20 18:35
• Resolved: 03/Mar/16 19:22

Description

Removing some deprecated things in CSVStrategy (SOLR-8764) exposed a bug: it's possible to redefine the public static CSVStrategy.{DEFAULT,EXCEL,TDF}_STRATEGY strategies, simply by calling their setters.

Right now that's happening in CSVParserTest.testUnicodeEscape(), where the default unicode escape interpretation is changed from false to true. And then if that test happens to run before CSVStrategyTest.testSetCSVStrategy(), which tests that the unicode escape interpretation on the default strategy is set to false, then the latter will fail.

Example failures: http://jenkins.thetaphi.de/job/Lucene-Solr-trunk-Linux/16079/ and http://jenkins.thetaphi.de/job/Lucene-Solr-trunk-MacOSX/3126/

Issue Links

• is broken by: SOLR-3213 Upgrade to commons-csv once it is released
• is broken by: SOLR-8764 Remove all deprecated methods and classes from master prior to the 6.0 release
• relates to: SOLR-14279 remove CSVStrategy's deprecated setters