Uploaded image for project: 'Solr'
  1. Solr
  2. SOLR-8778

Deprecate CSVStrategy's setters, and make its pre-configured strategies immutable

    XMLWordPrintableJSON

    Details

    • Type: Bug
    • Status: Resolved
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 6.0
    • Component/s: None
    • Labels:
      None

      Description

      Removing some deprecated things in CSVStrategy (SOLR-8764) exposed a bug: it's possible to redefine the public static CSVStrategy.{DEFAULT,EXCEL,TDF}_STRATEGY strategies, simply by calling their setters.

      Right now that's happening in CSVParserTest.testUnicodeEscape(), where the default unicode escape interpretation is changed from false to true. And then if that test happens to run before CSVStrategyTest.testSetCSVStrategy(), which tests that the unicode escape interpretation on the default strategy is set to false, then the latter will fail.

      Example failures: http://jenkins.thetaphi.de/job/Lucene-Solr-trunk-Linux/16079/ and http://jenkins.thetaphi.de/job/Lucene-Solr-trunk-MacOSX/3126/

        Attachments

        1. SOLR-8778.patch
          20 kB
          Steven Rowe

          Issue Links

            Activity

              People

              • Assignee:
                sarowe Steven Rowe
                Reporter:
                sarowe Steven Rowe
              • Votes:
                0 Vote for this issue
                Watchers:
                2 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved: