Uploaded image for project: 'Solr'
  1. Solr
  2. SOLR-8771

Multi-threaded core shutdown creates executor per core

    Details

    • Type: Bug
    • Status: Resolved
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 5.5.1, 6.0
    • Component/s: None
    • Labels:
      None

      Description

      The multi-threaded core shutdown that was added in SOLR-8615 has a bug where a new executor is created per core. This means we don't get any benefit from the parallel operations.

      Patch incoming shortly.

        Issue Links

          Activity

          Hide
          markrmiller@gmail.com Mark Miller added a comment -

          +1, good catch!

          Show
          markrmiller@gmail.com Mark Miller added a comment - +1, good catch!
          Hide
          jira-bot ASF subversion and git services added a comment -

          Commit 0f4f53a8f52cab0838bea2482aaa7d5012c5ecaa in lucene-solr's branch refs/heads/master from Mark Miller
          [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=0f4f53a ]

          SOLR-8771: Multi-threaded core shutdown creates executor per core.

          Show
          jira-bot ASF subversion and git services added a comment - Commit 0f4f53a8f52cab0838bea2482aaa7d5012c5ecaa in lucene-solr's branch refs/heads/master from Mark Miller [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=0f4f53a ] SOLR-8771 : Multi-threaded core shutdown creates executor per core.
          Hide
          anshumg Anshum Gupta added a comment -

          Back porting for 5.5.1.

          Show
          anshumg Anshum Gupta added a comment - Back porting for 5.5.1.
          Hide
          anshumg Anshum Gupta added a comment -

          For some reason the bot didn't comment on JIRA after the commits. Here are the back ports:
          branch_5x:

          commit 27ca43a16ed6d9ee83378b0532ba6c84a900eada
          Author: anshum <anshum@apache.org>
          Date:   Thu Apr 21 16:53:15 2016 -0700
          
              SOLR-8771: Fix broken build that broke during backporting to 5x
              
          commit 34340f540bc8a4ee8cbf80719093c677ffa0f128
          Author: Mark Miller <markrmiller@gmail.com>
          Date:   Tue Mar 1 12:13:56 2016 -0800
          
              SOLR-8771: Multi-threaded core shutdown creates executor per core.
          

          branch_5_5

          commit 297bdb63aa6720c6c204ce921f8bfc5854b4cfd4
          Author: anshum <anshum@apache.org>
          Date:   Thu Apr 21 16:53:15 2016 -0700
          
              SOLR-8771: Fix broken build that broke during backporting to 5x
          
          commit 9698d1bee31eb5f103f8894246acf7f8f5479194
          Author: Mark Miller <markrmiller@gmail.com>
          Date:   Tue Mar 1 12:13:56 2016 -0800
          
              SOLR-8771: Multi-threaded core shutdown creates executor per core.
          
          Show
          anshumg Anshum Gupta added a comment - For some reason the bot didn't comment on JIRA after the commits. Here are the back ports: branch_5x: commit 27ca43a16ed6d9ee83378b0532ba6c84a900eada Author: anshum <anshum@apache.org> Date: Thu Apr 21 16:53:15 2016 -0700 SOLR-8771: Fix broken build that broke during backporting to 5x commit 34340f540bc8a4ee8cbf80719093c677ffa0f128 Author: Mark Miller <markrmiller@gmail.com> Date: Tue Mar 1 12:13:56 2016 -0800 SOLR-8771: Multi-threaded core shutdown creates executor per core. branch_5_5 commit 297bdb63aa6720c6c204ce921f8bfc5854b4cfd4 Author: anshum <anshum@apache.org> Date: Thu Apr 21 16:53:15 2016 -0700 SOLR-8771: Fix broken build that broke during backporting to 5x commit 9698d1bee31eb5f103f8894246acf7f8f5479194 Author: Mark Miller <markrmiller@gmail.com> Date: Tue Mar 1 12:13:56 2016 -0800 SOLR-8771: Multi-threaded core shutdown creates executor per core.

            People

            • Assignee:
              Unassigned
              Reporter:
              mdrob Mike Drob
            • Votes:
              0 Vote for this issue
              Watchers:
              4 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development