Uploaded image for project: 'Solr'
  1. Solr
  2. SOLR-8746

Document the usage and difference between various overseer queues, rename methods if necessary

    Details

    • Type: Improvement
    • Status: Resolved
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 6.0
    • Component/s: SolrCloud
    • Labels:
      None

      Description

      The various overseer queues can use better javadocs to document their purpose and usage. The method names such as getInQueue, getInternalQueue and getCollectionQueue aren't descriptive enough.

      1. SOLR-8746.patch
        35 kB
        Shalin Shekhar Mangar

        Activity

        Hide
        shalinmangar Shalin Shekhar Mangar added a comment -
        1. Renamed Overseer.getInQueue to getStateUpdateQueue
        2. Renamed Overseer.getInternalQueue to getInternalWorkQueue
        3. Added javadocs for getStateUpdateQueue, getInternalWorkQueue, getCollectionQueue
        Show
        shalinmangar Shalin Shekhar Mangar added a comment - Renamed Overseer.getInQueue to getStateUpdateQueue Renamed Overseer.getInternalQueue to getInternalWorkQueue Added javadocs for getStateUpdateQueue, getInternalWorkQueue, getCollectionQueue
        Hide
        jira-bot ASF subversion and git services added a comment -

        Commit 41eb5e8542d260cdca630243c8800b5aa7e74623 in lucene-solr's branch refs/heads/master from Shalin Shekhar Mangar
        [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=41eb5e8 ]

        SOLR-8746: Renamed Overseer.getInQueue to getStateUpdateQueue, getInternalQueue to getInternalWorkQueue and added javadocs

        Show
        jira-bot ASF subversion and git services added a comment - Commit 41eb5e8542d260cdca630243c8800b5aa7e74623 in lucene-solr's branch refs/heads/master from Shalin Shekhar Mangar [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=41eb5e8 ] SOLR-8746 : Renamed Overseer.getInQueue to getStateUpdateQueue, getInternalQueue to getInternalWorkQueue and added javadocs
        Hide
        jira-bot ASF subversion and git services added a comment -

        Commit 9c97f2f3d26303a0354435fc011d3a747ce29ff7 in lucene-solr's branch refs/heads/master from Shalin Shekhar Mangar
        [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=9c97f2f ]

        SOLR-8746: Renamed Overseer.getInQueue to getStateUpdateQueue, getInternalQueue to getInternalWorkQueue and added javadocs

        Show
        jira-bot ASF subversion and git services added a comment - Commit 9c97f2f3d26303a0354435fc011d3a747ce29ff7 in lucene-solr's branch refs/heads/master from Shalin Shekhar Mangar [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=9c97f2f ] SOLR-8746 : Renamed Overseer.getInQueue to getStateUpdateQueue, getInternalQueue to getInternalWorkQueue and added javadocs
        Hide
        shalinmangar Shalin Shekhar Mangar added a comment -

        Thanks Scott Blum for prodding me to add these docs!

        Show
        shalinmangar Shalin Shekhar Mangar added a comment - Thanks Scott Blum for prodding me to add these docs!

          People

          • Assignee:
            shalinmangar Shalin Shekhar Mangar
            Reporter:
            shalinmangar Shalin Shekhar Mangar
          • Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development