Uploaded image for project: 'Solr'
  1. Solr
  2. SOLR-8715

New Admin UI's Schema screen fails for fields with stored=false and indexed content

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: 5.5, 6.0
    • Fix Version/s: 6.2, master (7.0)
    • Component/s: Admin UI
    • Labels:
    • Environment:

      mac, firefox

      Description

      In techproducts example, using new Admin UI and trying to load the Schema for text field causes blank screen and the Javascript error in the developer console:

      Error: row.flags is undefined
      getFieldProperties@http://localhost:8983/solr/js/angular/controllers/schema.js:482:40
      $scope.refresh/</<@http://localhost:8983/solr/js/angular/controllers/schema.js:76:38
      ....
      

      Tested with 5.5rc3

        Issue Links

          Activity

          Hide
          arafalov Alexandre Rafalovitch added a comment -

          I think the cause is around fields that are stored=false, because it fails for text and manu_exact. But it does NOT fail for text_rev, which is also stored=false.

          Show
          arafalov Alexandre Rafalovitch added a comment - I think the cause is around fields that are stored=false , because it fails for text and manu_exact . But it does NOT fail for text_rev , which is also stored=false .
          Hide
          arafalov Alexandre Rafalovitch added a comment -

          Confirm that the problem still exist for latest brach_6x. The screen breaks for text field for works for text_rev field. So, it is something very specific.

          Show
          arafalov Alexandre Rafalovitch added a comment - Confirm that the problem still exist for latest brach_6x. The screen breaks for text field for works for text_rev field. So, it is something very specific.
          Hide
          githubbot ASF GitHub Bot added a comment -

          GitHub user arafalov opened a pull request:

          https://github.com/apache/lucene-solr/pull/33

          Skip flag checks for when they are unavailable SOLR-8715

          Matches the special case in the LukeRequestHandler

          You can merge this pull request into a Git repository by running:

          $ git pull https://github.com/arafalov/lucene-solr-1 patch-2

          Alternatively you can review and apply these changes as the patch at:

          https://github.com/apache/lucene-solr/pull/33.patch

          To close this pull request, make a commit to your master/trunk branch
          with (at least) the following in the commit message:

          This closes #33


          commit a749033bab5d1773b1156355633f79c690ac9c11
          Author: Alexandre Rafalovitch <arafalov@gmail.com>
          Date: 2016-04-22T06:49:59Z

          Skip flag checks for when they are unavailable SOLR-8715

          Matches the special case in the LukeRequestHandler


          Show
          githubbot ASF GitHub Bot added a comment - GitHub user arafalov opened a pull request: https://github.com/apache/lucene-solr/pull/33 Skip flag checks for when they are unavailable SOLR-8715 Matches the special case in the LukeRequestHandler You can merge this pull request into a Git repository by running: $ git pull https://github.com/arafalov/lucene-solr-1 patch-2 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/lucene-solr/pull/33.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #33 commit a749033bab5d1773b1156355633f79c690ac9c11 Author: Alexandre Rafalovitch <arafalov@gmail.com> Date: 2016-04-22T06:49:59Z Skip flag checks for when they are unavailable SOLR-8715 Matches the special case in the LukeRequestHandler
          Hide
          upayavira Upayavira added a comment -

          patch looks fine, but couldn't you just do:

          if (!row.flags)

          rather than creating a new variable, rowFlags?

          Show
          upayavira Upayavira added a comment - patch looks fine, but couldn't you just do: if (!row.flags) rather than creating a new variable, rowFlags?
          Hide
          arafalov Alexandre Rafalovitch added a comment -

          You could. I just did it because it is used in the loop later as well. So, I wanted to make sure I definitely tested the same content.

          Oh and also, this only affected fields that had any content. So, text_rev field is also affected if any content is posted to it. Maybe this will have to consolidate JIRA issue title to something more meaningful.

          Show
          arafalov Alexandre Rafalovitch added a comment - You could. I just did it because it is used in the loop later as well. So, I wanted to make sure I definitely tested the same content. Oh and also, this only affected fields that had any content. So, text_rev field is also affected if any content is posted to it. Maybe this will have to consolidate JIRA issue title to something more meaningful.
          Hide
          arafalov Alexandre Rafalovitch added a comment -

          Is there anything else we need for this one? Would be nice if it could be pushed into 5.5.1 as well, given how trivial the fix is.

          Show
          arafalov Alexandre Rafalovitch added a comment - Is there anything else we need for this one? Would be nice if it could be pushed into 5.5.1 as well, given how trivial the fix is.
          Hide
          arafalov Alexandre Rafalovitch added a comment -

          Is this one too late for 6.1? We figured the solution already, it just needs to be committed.

          Show
          arafalov Alexandre Rafalovitch added a comment - Is this one too late for 6.1? We figured the solution already, it just needs to be committed.
          Hide
          arafalov Alexandre Rafalovitch added a comment -

          5.5.3 might be coming out soon. Any chance we can fold this into that? We already have the solution tested and it is super trivial. Yet, it stops the new Admin UI being usable in fairly common situations.

          Show
          arafalov Alexandre Rafalovitch added a comment - 5.5.3 might be coming out soon. Any chance we can fold this into that? We already have the solution tested and it is super trivial. Yet, it stops the new Admin UI being usable in fairly common situations.
          Hide
          githubbot ASF GitHub Bot added a comment -

          GitHub user arafalov opened a pull request:

          https://github.com/apache/lucene-solr/pull/55

          SOLR-8715: Added special condition to match server

          One-line fix. Just a missed condition to match server-side special case.

          You can merge this pull request into a Git repository by running:

          $ git pull https://github.com/arafalov/lucene-solr-contributions alex-SOLR-8715

          Alternatively you can review and apply these changes as the patch at:

          https://github.com/apache/lucene-solr/pull/55.patch

          To close this pull request, make a commit to your master/trunk branch
          with (at least) the following in the commit message:

          This closes #55


          commit 8a6f462458a1e6610027271b4212f132dee33df5
          Author: Alexandre Rafalovitch <arafalov@gmail.com>
          Date: 2016-07-26T23:09:09Z

          SOLR-8715: Added special condition to match server


          Show
          githubbot ASF GitHub Bot added a comment - GitHub user arafalov opened a pull request: https://github.com/apache/lucene-solr/pull/55 SOLR-8715 : Added special condition to match server One-line fix. Just a missed condition to match server-side special case. You can merge this pull request into a Git repository by running: $ git pull https://github.com/arafalov/lucene-solr-contributions alex- SOLR-8715 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/lucene-solr/pull/55.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #55 commit 8a6f462458a1e6610027271b4212f132dee33df5 Author: Alexandre Rafalovitch <arafalov@gmail.com> Date: 2016-07-26T23:09:09Z SOLR-8715 : Added special condition to match server
          Hide
          jira-bot ASF subversion and git services added a comment -

          Commit cea8a488f0d48041abb4be0dbe29ab81f04522bf in lucene-solr's branch refs/heads/master from Alexandre Rafalovitch
          [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=cea8a48 ]

          SOLR-8715: Admin UI - Fix schema special case

          Show
          jira-bot ASF subversion and git services added a comment - Commit cea8a488f0d48041abb4be0dbe29ab81f04522bf in lucene-solr's branch refs/heads/master from Alexandre Rafalovitch [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=cea8a48 ] SOLR-8715 : Admin UI - Fix schema special case
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user arafalov closed the pull request at:

          https://github.com/apache/lucene-solr/pull/33

          Show
          githubbot ASF GitHub Bot added a comment - Github user arafalov closed the pull request at: https://github.com/apache/lucene-solr/pull/33
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user arafalov closed the pull request at:

          https://github.com/apache/lucene-solr/pull/55

          Show
          githubbot ASF GitHub Bot added a comment - Github user arafalov closed the pull request at: https://github.com/apache/lucene-solr/pull/55
          Hide
          jira-bot ASF subversion and git services added a comment -

          Commit a6ce37022e744f5ba535b1cb52c3661aa8cab687 in lucene-solr's branch refs/heads/branch_6x from Alexandre Rafalovitch
          [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=a6ce370 ]

          SOLR-8715: Admin UI - Fix schema special case

          Show
          jira-bot ASF subversion and git services added a comment - Commit a6ce37022e744f5ba535b1cb52c3661aa8cab687 in lucene-solr's branch refs/heads/branch_6x from Alexandre Rafalovitch [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=a6ce370 ] SOLR-8715 : Admin UI - Fix schema special case
          Hide
          mikemccand Michael McCandless added a comment -

          Bulk close resolved issues after 6.2.0 release.

          Show
          mikemccand Michael McCandless added a comment - Bulk close resolved issues after 6.2.0 release.

            People

            • Assignee:
              arafalov Alexandre Rafalovitch
              Reporter:
              arafalov Alexandre Rafalovitch
            • Votes:
              0 Vote for this issue
              Watchers:
              6 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development