Uploaded image for project: 'Solr'
  1. Solr
  2. SOLR-8712

Variable solr.core.instanceDir no longer resolved

    Details

    • Type: Bug
    • Status: Resolved
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: 5.5
    • Fix Version/s: 5.5.1, 6.0
    • Component/s: None
    • Labels:
      None

      Description

      In 5.4.1 standalone mode it was possible to use ${solr.core.instanceDir} in the data import config file. This property is no longer available in 5.5.0.

      1. SOLR-8712.patch
        3 kB
        Alan Woodward

        Activity

        Hide
        elyograg Shawn Heisey added a comment -

        Properties like this have stopped working in the past. SOLR-5162 is one example.

        I think that SOLR-8336 is a possible cause of this, with this patch hunk for CoreDescriptor.java:

        @@ -47,8 +50,6 @@ public class CoreDescriptor {
           // Properties file name constants
           public static final String CORE_NAME = "name";
           public static final String CORE_CONFIG = "config";
        -  public static final String CORE_INSTDIR = "instanceDir";
        -  public static final String CORE_ABS_INSTDIR = "absoluteInstDir";
           public static final String CORE_DATADIR = "dataDir";
           public static final String CORE_ULOGDIR = "ulogDir";
           public static final String CORE_SCHEMA = "schema";
        @@ -91,13 +92,12 @@ public class CoreDescriptor {
               .build();
         
           private static ImmutableList<String> requiredProperties = ImmutableList.of(
        -      CORE_NAME, CORE_INSTDIR, CORE_ABS_INSTDIR
        +      CORE_NAME
           );
         
           public static ImmutableList<String> standardPropNames = ImmutableList.of(
               CORE_NAME,
               CORE_CONFIG,
        -      CORE_INSTDIR,
               CORE_DATADIR,
               CORE_ULOGDIR,
               CORE_SCHEMA,
        

        Alan Woodward, SOLR-8336 is yours. Would that cause this problem, and if so, any thoughts about fixing it?

        Show
        elyograg Shawn Heisey added a comment - Properties like this have stopped working in the past. SOLR-5162 is one example. I think that SOLR-8336 is a possible cause of this, with this patch hunk for CoreDescriptor.java: @@ -47,8 +50,6 @@ public class CoreDescriptor { // Properties file name constants public static final String CORE_NAME = "name" ; public static final String CORE_CONFIG = "config" ; - public static final String CORE_INSTDIR = "instanceDir" ; - public static final String CORE_ABS_INSTDIR = "absoluteInstDir" ; public static final String CORE_DATADIR = "dataDir" ; public static final String CORE_ULOGDIR = "ulogDir" ; public static final String CORE_SCHEMA = "schema" ; @@ -91,13 +92,12 @@ public class CoreDescriptor { .build(); private static ImmutableList< String > requiredProperties = ImmutableList.of( - CORE_NAME, CORE_INSTDIR, CORE_ABS_INSTDIR + CORE_NAME ); public static ImmutableList< String > standardPropNames = ImmutableList.of( CORE_NAME, CORE_CONFIG, - CORE_INSTDIR, CORE_DATADIR, CORE_ULOGDIR, CORE_SCHEMA, Alan Woodward , SOLR-8336 is yours. Would that cause this problem, and if so, any thoughts about fixing it?
        Hide
        romseygeek Alan Woodward added a comment -

        Yes, we need to add instanceDir back into the list of substitutable properties. I'll do that, plus a test to make sure that we catch this sort of thing in future.

        Show
        romseygeek Alan Woodward added a comment - Yes, we need to add instanceDir back into the list of substitutable properties. I'll do that, plus a test to make sure that we catch this sort of thing in future.
        Hide
        romseygeek Alan Woodward added a comment -

        Patch fixing the issue, plus test.

        Show
        romseygeek Alan Woodward added a comment - Patch fixing the issue, plus test.
        Hide
        jira-bot ASF subversion and git services added a comment -

        Commit 5c0240219a1450aab3d14067605bc35d0b6b3c0b in lucene-solr's branch refs/heads/master from Alan Woodward
        [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=5c02402 ]

        SOLR-8712: Variable solr.core.instanceDir was not being resolved

        Show
        jira-bot ASF subversion and git services added a comment - Commit 5c0240219a1450aab3d14067605bc35d0b6b3c0b in lucene-solr's branch refs/heads/master from Alan Woodward [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=5c02402 ] SOLR-8712 : Variable solr.core.instanceDir was not being resolved
        Hide
        jira-bot ASF subversion and git services added a comment -

        Commit 4e1c381b32b7b7630db5f1e24a3a8ab62605ced1 in lucene-solr's branch refs/heads/branch_5_5 from Alan Woodward
        [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=4e1c381 ]

        SOLR-8712: Variable solr.core.instanceDir was not being resolved

        Show
        jira-bot ASF subversion and git services added a comment - Commit 4e1c381b32b7b7630db5f1e24a3a8ab62605ced1 in lucene-solr's branch refs/heads/branch_5_5 from Alan Woodward [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=4e1c381 ] SOLR-8712 : Variable solr.core.instanceDir was not being resolved
        Hide
        romseygeek Alan Woodward added a comment -

        Fixed - thanks for raising the issue Kristine!

        Show
        romseygeek Alan Woodward added a comment - Fixed - thanks for raising the issue Kristine!

          People

          • Assignee:
            romseygeek Alan Woodward
            Reporter:
            tinexw Kristine Jetzke
          • Votes:
            0 Vote for this issue
            Watchers:
            4 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development