Uploaded image for project: 'Solr'
  1. Solr
  2. SOLR-8694

DistributedMap/Queue simplifications and fixes.

    Details

    • Flags:
      Patch

      Description

      Bugfix in DistributedQueue, it could add too many watchers since it assumed the watcher was cleared on connection events.

      Huge simplification to DistributedMap; it implemented a lot of tricky stuff that no one is actually using.

        Issue Links

          Activity

          Hide
          dragonsinth Scott Blum added a comment -
          Show
          dragonsinth Scott Blum added a comment - Shalin Shekhar Mangar
          Hide
          markrmiller@gmail.com Mark Miller added a comment -

          Nice catch! We should audit all our Watcher process methods for this. It's been awhile since we did.

          Bummer, doesn't look like any explicit tests already exist for this class to build on and try and catch this.

          Show
          markrmiller@gmail.com Mark Miller added a comment - Nice catch! We should audit all our Watcher process methods for this. It's been awhile since we did. Bummer, doesn't look like any explicit tests already exist for this class to build on and try and catch this.
          Hide
          dragonsinth Scott Blum added a comment -

          I did audit all the Watcher process methods.
          https://issues.apache.org/jira/browse/SOLR-8695

          Show
          dragonsinth Scott Blum added a comment - I did audit all the Watcher process methods. https://issues.apache.org/jira/browse/SOLR-8695
          Hide
          jira-bot ASF subversion and git services added a comment -

          Commit 32fbca6ea7b65043041e622660e07915f04090fe in lucene-solr's branch refs/heads/master from markrmiller
          [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=32fbca6 ]

          SOLR-8694: DistributedMap/Queue can create too many Watchers and some code simplification.

          Show
          jira-bot ASF subversion and git services added a comment - Commit 32fbca6ea7b65043041e622660e07915f04090fe in lucene-solr's branch refs/heads/master from markrmiller [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=32fbca6 ] SOLR-8694 : DistributedMap/Queue can create too many Watchers and some code simplification.
          Hide
          markrmiller@gmail.com Mark Miller added a comment -

          Thanks Scott!

          Show
          markrmiller@gmail.com Mark Miller added a comment - Thanks Scott!
          Hide
          anshumg Anshum Gupta added a comment -

          Reopening to back port for 5.5.1

          Show
          anshumg Anshum Gupta added a comment - Reopening to back port for 5.5.1
          Hide
          dragonsinth Scott Blum added a comment -

          I have a compatible patch if you'd like me to take this one as well.

          Show
          dragonsinth Scott Blum added a comment - I have a compatible patch if you'd like me to take this one as well.
          Hide
          dragonsinth Scott Blum added a comment -

          In progress.

          Show
          dragonsinth Scott Blum added a comment - In progress.
          Hide
          jira-bot ASF subversion and git services added a comment -

          Commit bbae36aa92c58cdbe031ea447bcbd9ae66f5138c in lucene-solr's branch refs/heads/branch_5x from markrmiller
          [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=bbae36a ]

          SOLR-8694: DistributedMap/Queue can create too many Watchers and some code simplification.

          Show
          jira-bot ASF subversion and git services added a comment - Commit bbae36aa92c58cdbe031ea447bcbd9ae66f5138c in lucene-solr's branch refs/heads/branch_5x from markrmiller [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=bbae36a ] SOLR-8694 : DistributedMap/Queue can create too many Watchers and some code simplification.
          Hide
          jira-bot ASF subversion and git services added a comment -

          Commit 6d3402188d3b7e2e12fc27d98d643a87feffa147 in lucene-solr's branch refs/heads/branch_5_5 from markrmiller
          [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=6d34021 ]

          SOLR-8694: DistributedMap/Queue can create too many Watchers and some code simplification.

          Show
          jira-bot ASF subversion and git services added a comment - Commit 6d3402188d3b7e2e12fc27d98d643a87feffa147 in lucene-solr's branch refs/heads/branch_5_5 from markrmiller [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=6d34021 ] SOLR-8694 : DistributedMap/Queue can create too many Watchers and some code simplification.
          Hide
          jira-bot ASF subversion and git services added a comment -

          Commit 244649bc74b204b9e595607e877f9913abee28dc in lucene-solr's branch refs/heads/branch_5x from markrmiller
          [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=244649bc ]

          SOLR-8694: DistributedMap/Queue can create too many Watchers and some code simplification.

          Show
          jira-bot ASF subversion and git services added a comment - Commit 244649bc74b204b9e595607e877f9913abee28dc in lucene-solr's branch refs/heads/branch_5x from markrmiller [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=244649bc ] SOLR-8694 : DistributedMap/Queue can create too many Watchers and some code simplification.
          Hide
          anshumg Anshum Gupta added a comment -

          Seems like a wrong commit got tagged here. It's just some formatting fix in CHANGES.txt so should be fine.

          Show
          anshumg Anshum Gupta added a comment - Seems like a wrong commit got tagged here. It's just some formatting fix in CHANGES.txt so should be fine.
          Hide
          jira-bot ASF subversion and git services added a comment -

          Commit 0e69a562857da9fc68cfc104bddfdea4c493476f in lucene-solr's branch refs/heads/branch_5_5 from markrmiller
          [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=0e69a56 ]

          SOLR-8694: DistributedMap/Queue can create too many Watchers and some code simplification.

          Show
          jira-bot ASF subversion and git services added a comment - Commit 0e69a562857da9fc68cfc104bddfdea4c493476f in lucene-solr's branch refs/heads/branch_5_5 from markrmiller [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=0e69a56 ] SOLR-8694 : DistributedMap/Queue can create too many Watchers and some code simplification.

            People

            • Assignee:
              dragonsinth Scott Blum
              Reporter:
              dragonsinth Scott Blum
            • Votes:
              0 Vote for this issue
              Watchers:
              4 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development