Details

    • Type: Improvement
    • Status: Resolved
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 6.0
    • Component/s: None
    • Labels:
      None

      Description

      Given that the new index fingerprinting code that happens during peersync has some performance cost, perhaps it should be made configurable?

      1. SOLR-8690.patch
        2 kB
        Yonik Seeley

        Activity

        Hide
        yseeley@gmail.com Yonik Seeley added a comment - - edited

        So assuming that people want this to be configurable, the config could either go in
        solr.xml or solrconfig.xml

        It's also super-expert enough (this is really only an escape hatch in case something goes wrong and fingerprinting overhead turns out to be an issue for someone) that another option is it could just be system property w/o any corresponding entry in solr.xml or solrconfig.xml?

        Thoughts?

        Show
        yseeley@gmail.com Yonik Seeley added a comment - - edited So assuming that people want this to be configurable, the config could either go in solr.xml or solrconfig.xml It's also super-expert enough (this is really only an escape hatch in case something goes wrong and fingerprinting overhead turns out to be an issue for someone) that another option is it could just be system property w/o any corresponding entry in solr.xml or solrconfig.xml? Thoughts?
        Hide
        markrmiller@gmail.com Mark Miller added a comment -

        Feels to me like at most it should not be first class config, but a simple system prop. The old behavior is buggy with the current system. I can see wanting a safety valve to disable it in case you hit something that is worse for you then the bug and don't have time to wait for a fix, but I'd hate to support this with first class configuration.

        Show
        markrmiller@gmail.com Mark Miller added a comment - Feels to me like at most it should not be first class config, but a simple system prop. The old behavior is buggy with the current system. I can see wanting a safety valve to disable it in case you hit something that is worse for you then the bug and don't have time to wait for a fix, but I'd hate to support this with first class configuration.
        Hide
        yseeley@gmail.com Yonik Seeley added a comment -

        Sounds good to me, I'll go with a system property of solr.disableFingerprint

        Show
        yseeley@gmail.com Yonik Seeley added a comment - Sounds good to me, I'll go with a system property of solr.disableFingerprint
        Hide
        yseeley@gmail.com Yonik Seeley added a comment -

        Here's the patch.

        Show
        yseeley@gmail.com Yonik Seeley added a comment - Here's the patch.
        Hide
        jira-bot ASF subversion and git services added a comment -

        Commit f47e6b220066565cd7741ac76b75b9eb56091b87 in lucene-solr's branch refs/heads/master from Yonik Seeley
        [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=f47e6b2 ]

        SOLR-8690: add solr.disableFingerprint system property

        Show
        jira-bot ASF subversion and git services added a comment - Commit f47e6b220066565cd7741ac76b75b9eb56091b87 in lucene-solr's branch refs/heads/master from Yonik Seeley [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=f47e6b2 ] SOLR-8690 : add solr.disableFingerprint system property

          People

          • Assignee:
            yseeley@gmail.com Yonik Seeley
            Reporter:
            yseeley@gmail.com Yonik Seeley
          • Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development