Uploaded image for project: 'Solr'
  1. Solr
  2. SOLR-8676

It's not possible to use a different log4.properties file on windows

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: 5.4.1
    • Fix Version/s: 5.5.2, 5.6, 6.0.2, 6.1, master (7.0)
    • Component/s: None
    • Labels:
      None

      Description

      It's currently not possible to change the location of the log4j.properties file on windows. The value of LOG4J_CONFIG always gets replaced with the default value server\resources\log4j.properties. Thus, this file inside the server directory needs to be changed after every update.

      See attached patch for a fix. Unfortunately, I couldn't figure out why LOG4J_CONFIG was set to empty. I tested manually that logging still works when running an example so I hope that this line is really just obsolete.

      1. SOLR-8676.patch
        1 kB
        Mikhail Khludnev
      2. SOLR-8676.patch
        0.8 kB
        Kristine Jetzke
      3. verifying SOLR-8676.txt
        1 kB
        Mikhail Khludnev

        Activity

        Hide
        mkhludnev Mikhail Khludnev added a comment -

        Timothy Potter, do you have an any objections? I see that LOG4J_CONFIG set to empty for non-example launch during SOLR-6833.

        Show
        mkhludnev Mikhail Khludnev added a comment - Timothy Potter , do you have an any objections? I see that LOG4J_CONFIG set to empty for non-example launch during SOLR-6833 .
        Hide
        mkhludnev Mikhail Khludnev added a comment -

        briefly checked in on old windows, it seems fine. see attach. Will commit tomorrow or so.

        Show
        mkhludnev Mikhail Khludnev added a comment - briefly checked in on old windows, it seems fine. see attach. Will commit tomorrow or so.
        Hide
        iorixxx Ahmet Arslan added a comment -

        Mikhail Khludnev do you mind looking into SOLR-8445 too?

        Show
        iorixxx Ahmet Arslan added a comment - Mikhail Khludnev do you mind looking into SOLR-8445 too?
        Hide
        jira-bot ASF subversion and git services added a comment -

        Commit 00602a3a7a3f6542ff2993bf6f2fb8f6edbd9c22 in lucene-solr's branch refs/heads/master from Mikhail Khludnev
        [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=00602a3 ]

        SOLR-8676: keep LOG4J_CONFIG in solr.cmd

        Show
        jira-bot ASF subversion and git services added a comment - Commit 00602a3a7a3f6542ff2993bf6f2fb8f6edbd9c22 in lucene-solr's branch refs/heads/master from Mikhail Khludnev [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=00602a3 ] SOLR-8676 : keep LOG4J_CONFIG in solr.cmd
        Hide
        jira-bot ASF subversion and git services added a comment -

        Commit 87d46225cdc80f515ecd191fe618d2942eab8289 in lucene-solr's branch refs/heads/branch_6x from Mikhail Khludnev
        [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=87d4622 ]

        SOLR-8676: keep LOG4J_CONFIG in solr.cmd

        Show
        jira-bot ASF subversion and git services added a comment - Commit 87d46225cdc80f515ecd191fe618d2942eab8289 in lucene-solr's branch refs/heads/branch_6x from Mikhail Khludnev [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=87d4622 ] SOLR-8676 : keep LOG4J_CONFIG in solr.cmd
        Hide
        steve_rowe Steve Rowe added a comment -

        Reopening to backport to 6.0.2, 5.6 and 5.5.2.

        Show
        steve_rowe Steve Rowe added a comment - Reopening to backport to 6.0.2, 5.6 and 5.5.2.
        Hide
        jira-bot ASF subversion and git services added a comment -

        Commit 3d8a6b0cb8be7c5e7fc683d13034d74d46238c44 in lucene-solr's branch refs/heads/branch_5_5 from Mikhail Khludnev
        [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=3d8a6b0 ]

        SOLR-8676: keep LOG4J_CONFIG in solr.cmd

        Show
        jira-bot ASF subversion and git services added a comment - Commit 3d8a6b0cb8be7c5e7fc683d13034d74d46238c44 in lucene-solr's branch refs/heads/branch_5_5 from Mikhail Khludnev [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=3d8a6b0 ] SOLR-8676 : keep LOG4J_CONFIG in solr.cmd
        Hide
        jira-bot ASF subversion and git services added a comment -

        Commit c20b41fe6b1d023a5bdf30e39afa1b470597bcc5 in lucene-solr's branch refs/heads/branch_5x from Mikhail Khludnev
        [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=c20b41f ]

        SOLR-8676: keep LOG4J_CONFIG in solr.cmd

        Show
        jira-bot ASF subversion and git services added a comment - Commit c20b41fe6b1d023a5bdf30e39afa1b470597bcc5 in lucene-solr's branch refs/heads/branch_5x from Mikhail Khludnev [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=c20b41f ] SOLR-8676 : keep LOG4J_CONFIG in solr.cmd
        Hide
        jira-bot ASF subversion and git services added a comment -

        Commit 60c140c244c4f93bbd3af2fe1b6244101a8db971 in lucene-solr's branch refs/heads/branch_6_0 from Mikhail Khludnev
        [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=60c140c ]

        SOLR-8676: keep LOG4J_CONFIG in solr.cmd

        Show
        jira-bot ASF subversion and git services added a comment - Commit 60c140c244c4f93bbd3af2fe1b6244101a8db971 in lucene-solr's branch refs/heads/branch_6_0 from Mikhail Khludnev [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=60c140c ] SOLR-8676 : keep LOG4J_CONFIG in solr.cmd
        Hide
        steve_rowe Steve Rowe added a comment -

        Bulk close issues released with 5.5.2.

        Show
        steve_rowe Steve Rowe added a comment - Bulk close issues released with 5.5.2.

          People

          • Assignee:
            mkhludnev Mikhail Khludnev
            Reporter:
            tinexw Kristine Jetzke
          • Votes:
            2 Vote for this issue
            Watchers:
            7 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development