Uploaded image for project: 'Solr'
  1. Solr
  2. SOLR-8666

Add header to SearchHandler to indicate whether solr is connection to zk

    Details

    • Type: Improvement
    • Status: Closed
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 6.0
    • Component/s: None
    • Labels:
      None

      Description

      Currently solr update requests error out if a zookeeper check fails, however SearchHandler does not do these checks. As a result, if a request is sent to a node which should be part of a SolrCloud but is not connected to zookeeper and thinks that its Active, it's possible the response is composed of stale data.

      The purpose of this header is to allow the client to decide whether or not the result data should be considered valid.

      This patch also returns the zkConnected header in the ping handler to allow external health checks to use this information.

      See SOLR-8599 for an example of when this situation can arise.

        Activity

        Hide
        k317h Keith Laban added a comment -

        Patch added

        Show
        k317h Keith Laban added a comment - Patch added
        Hide
        jira-bot ASF subversion and git services added a comment -

        Commit d6105334a0fb46dbb2b5d4a4f8a9d9355a6d7a17 in lucene-solr's branch refs/heads/master from Dennis Gove
        [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=d610533 ]

        SOLR-8666: Adds header 'zkConnected' to response of SearchHandler and PingRequestHandler

        Header is used to notify the client when a connection to zookeeper has been lost and there is a possibility of stale data on the node the request is coming from.

        Show
        jira-bot ASF subversion and git services added a comment - Commit d6105334a0fb46dbb2b5d4a4f8a9d9355a6d7a17 in lucene-solr's branch refs/heads/master from Dennis Gove [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=d610533 ] SOLR-8666 : Adds header 'zkConnected' to response of SearchHandler and PingRequestHandler Header is used to notify the client when a connection to zookeeper has been lost and there is a possibility of stale data on the node the request is coming from.
        Hide
        jira-bot ASF subversion and git services added a comment -

        Commit a7a6663720638c84d409088bfe89cb806c41877d in lucene-solr's branch refs/heads/master from Dennis Gove
        [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=a7a6663 ]

        SOLR-8718: Corrects location for note for SOLR-8666 in solr/CHANGES.txt

        Show
        jira-bot ASF subversion and git services added a comment - Commit a7a6663720638c84d409088bfe89cb806c41877d in lucene-solr's branch refs/heads/master from Dennis Gove [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=a7a6663 ] SOLR-8718 : Corrects location for note for SOLR-8666 in solr/CHANGES.txt
        Hide
        markrmiller@gmail.com Mark Miller added a comment -

        it's possible the response is composed of stale data.

        Eventually consistent

        Good idea - only glanced at the patch, but looks good.

        Show
        markrmiller@gmail.com Mark Miller added a comment - it's possible the response is composed of stale data. Eventually consistent Good idea - only glanced at the patch, but looks good.
        Hide
        jira-bot ASF subversion and git services added a comment -

        Commit a7a6663720638c84d409088bfe89cb806c41877d in lucene-solr's branch refs/heads/apiv2 from Dennis Gove
        [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=a7a6663 ]

        SOLR-8718: Corrects location for note for SOLR-8666 in solr/CHANGES.txt

        Show
        jira-bot ASF subversion and git services added a comment - Commit a7a6663720638c84d409088bfe89cb806c41877d in lucene-solr's branch refs/heads/apiv2 from Dennis Gove [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=a7a6663 ] SOLR-8718 : Corrects location for note for SOLR-8666 in solr/CHANGES.txt
        Hide
        hossman Hoss Man added a comment -

        I added an explanation of this to the ref guide, i would appreciate if folks more intimately familiar with the issue would review & sanity check ... comment on the page as needed...

        https://cwiki.apache.org/confluence/display/solr/Read+and+Write+Side+Fault+Tolerance

        Show
        hossman Hoss Man added a comment - I added an explanation of this to the ref guide, i would appreciate if folks more intimately familiar with the issue would review & sanity check ... comment on the page as needed... https://cwiki.apache.org/confluence/display/solr/Read+and+Write+Side+Fault+Tolerance

          People

          • Assignee:
            dpgove Dennis Gove
            Reporter:
            k317h Keith Laban
          • Votes:
            0 Vote for this issue
            Watchers:
            4 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development