Solr
  1. Solr
  2. SOLR-8651

The commitWithin parameter is not passed on for deleteById in UpdateRequest for distributed queries

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 5.5, 6.0
    • Component/s: SolrJ

      Description

      The commitWithin parameter is not passed on for deleteById in UpdateRequest, resulting in it not working.

      Adding a one-line fix plus test that fail before adding the line and passes after.

      1. fix-solrj-delete-commitWithin.patch
        5 kB
        Jessica Cheng Mallet
      2. SOLR-8651.patch
        7 kB
        Erick Erickson

        Activity

        Hide
        ASF subversion and git services added a comment -

        Commit 7053a99f4939cb2780cdca68d5333cfdb09267ad in lucene-solr's branch refs/heads/master from Erick Erickson
        [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=7053a99 ]

        SOLR-8651: The commitWithin parameter is not passed on for deleteById in UpdateRequest for distributed queries

        Show
        ASF subversion and git services added a comment - Commit 7053a99f4939cb2780cdca68d5333cfdb09267ad in lucene-solr's branch refs/heads/master from Erick Erickson [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=7053a99 ] SOLR-8651 : The commitWithin parameter is not passed on for deleteById in UpdateRequest for distributed queries
        Hide
        Erick Erickson added a comment -

        Final patch with CHANGES.txt entry.

        Changed System.currentTimeMillis to use RTimer in test.

        Thanks Jessica!

        Show
        Erick Erickson added a comment - Final patch with CHANGES.txt entry. Changed System.currentTimeMillis to use RTimer in test. Thanks Jessica!
        Hide
        ASF subversion and git services added a comment -

        Commit 8ff9ebdad83a41edcdc90c72a5d1afdf75e41234 in lucene-solr's branch refs/heads/branch_5x from Erick Erickson
        [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=8ff9ebd ]

        SOLR-8651: The commitWithin parameter is not passed on for deleteById in UpdateRequest for distributed queries

        Show
        ASF subversion and git services added a comment - Commit 8ff9ebdad83a41edcdc90c72a5d1afdf75e41234 in lucene-solr's branch refs/heads/branch_5x from Erick Erickson [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=8ff9ebd ] SOLR-8651 : The commitWithin parameter is not passed on for deleteById in UpdateRequest for distributed queries
        Hide
        Erick Erickson added a comment -

        Thanks Jessica!

        Show
        Erick Erickson added a comment - Thanks Jessica!
        Hide
        ASF subversion and git services added a comment -

        Commit b5823b50db14d93b546fa898e33ad3dfea58df17 in lucene-solr's branch refs/heads/master from Erick Erickson
        [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=b5823b5 ]

        SOLR-8658: Fix test failure introduced in SOLR-8651

        Show
        ASF subversion and git services added a comment - Commit b5823b50db14d93b546fa898e33ad3dfea58df17 in lucene-solr's branch refs/heads/master from Erick Erickson [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=b5823b5 ] SOLR-8658 : Fix test failure introduced in SOLR-8651
        Hide
        ASF subversion and git services added a comment -

        Commit f4f1486895bf9cc18bb4e9f89a110c50ae63f59c in lucene-solr's branch refs/heads/branch_5x from Erick Erickson
        [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=f4f1486 ]

        SOLR-8658: Fix test failure introduced in SOLR-8651

        Show
        ASF subversion and git services added a comment - Commit f4f1486895bf9cc18bb4e9f89a110c50ae63f59c in lucene-solr's branch refs/heads/branch_5x from Erick Erickson [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=f4f1486 ] SOLR-8658 : Fix test failure introduced in SOLR-8651

          People

          • Assignee:
            Erick Erickson
            Reporter:
            Jessica Cheng Mallet
          • Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development