[SOLR-864] DataImportHandler does not catch and log Errors

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 1.3
• Fix Version/s: 1.4
• Component/s: contrib - DataImportHandler
• Assignee: Shalin Shekhar Mangar
• Reporter: Shalin Shekhar Mangar
• Created: 16/Nov/08 06:31
• Updated: 10/Nov/09 15:51
• Resolved: 17/Nov/08 08:26

Description

DataImportHandler catches only 'Exception' types but not 'Error' sub-classes, therefore, errors like StackOverflowError and others silently slip by and are not logged anywhere. Even though DataImportHandler does not commit documents in such case, in the absence of an entry in the log, it becomes very difficult to track down the cause.

Look at http://markmail.org/message/mhqae66p262d5mcc for discussion on solr-user.

DataImportHandler should catch Throwable and log all errors/exceptions.