Solr
  1. Solr
  2. SOLR-864

DataImportHandler does not catch and log Errors

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 1.3
    • Fix Version/s: 1.4
    • Labels:
      None

      Description

      DataImportHandler catches only 'Exception' types but not 'Error' sub-classes, therefore, errors like StackOverflowError and others silently slip by and are not logged anywhere. Even though DataImportHandler does not commit documents in such case, in the absence of an entry in the log, it becomes very difficult to track down the cause.

      Look at http://markmail.org/message/mhqae66p262d5mcc for discussion on solr-user.

      DataImportHandler should catch Throwable and log all errors/exceptions.

      1. SOLR-864.patch
        4 kB
        Shalin Shekhar Mangar

        Activity

        Hide
        Shalin Shekhar Mangar added a comment -

        Attached patch catches and logs all Throwable.

        All Errors are assumed to be severe and import is aborted regardless of the 'onError' configuration.

        Show
        Shalin Shekhar Mangar added a comment - Attached patch catches and logs all Throwable. All Errors are assumed to be severe and import is aborted regardless of the 'onError' configuration.
        Hide
        Shalin Shekhar Mangar added a comment -

        Committed revision 718187.

        Show
        Shalin Shekhar Mangar added a comment - Committed revision 718187.
        Hide
        Grant Ingersoll added a comment -

        Bulk close for Solr 1.4

        Show
        Grant Ingersoll added a comment - Bulk close for Solr 1.4

          People

          • Assignee:
            Shalin Shekhar Mangar
            Reporter:
            Shalin Shekhar Mangar
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development