Solr
  1. Solr
  2. SOLR-863

SolrCore.initIndex should close the directory it gets for clearing the lock and use the DirectoryFactory

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Trivial Trivial
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 1.4
    • Component/s: None
    • Labels:
      None

      Description

      Could put the close in a finally as well, but if you get an exception here I don't think your going anywhere anyway, so probably doesn't matter (it probably doesn't even matter that its not closed, but it should be).

      1. SOLR-863.patch
        1 kB
        Shalin Shekhar Mangar
      2. SOLR-863.patch
        0.9 kB
        Mark Miller

        Activity

        Hide
        Shalin Shekhar Mangar added a comment -

        Made sure we don't call close on a null dir. I plan to commit shortly.

        Show
        Shalin Shekhar Mangar added a comment - Made sure we don't call close on a null dir. I plan to commit shortly.
        Hide
        Shalin Shekhar Mangar added a comment -

        Committed revision 727719.

        Thanks Mark!

        Show
        Shalin Shekhar Mangar added a comment - Committed revision 727719. Thanks Mark!
        Hide
        Grant Ingersoll added a comment -

        Bulk close for Solr 1.4

        Show
        Grant Ingersoll added a comment - Bulk close for Solr 1.4

          People

          • Assignee:
            Shalin Shekhar Mangar
            Reporter:
            Mark Miller
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development