Uploaded image for project: 'Solr'
  1. Solr
  2. SOLR-8626

[ANGULAR] 404 error when clicking nodes in cloud graph view

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 6.2, master (7.0)
    • Component/s: Admin UI
    • Labels:
      None

      Description

      Reproduce:

      1. bin/solr start -c
      2. bin/solr create -c mycoll
      3. Goto http://localhost:8983/solr/#/~cloud
      4. Click a collection name in the graph -> 404 error. URL: /solr/mycoll/#/~cloud
      5. Click a shard name in the graph -> 404 error. URL: /solr/shard1/#/~cloud

      Only verified in Trunk, but probably exists in 5.4 as well

      1. SOLR-8626.patch
        3 kB
        Trey Grainger

        Issue Links

          Activity

          Hide
          upayavira Upayavira added a comment -

          Yikes. I don't think I ever clicked on those. Good catch.

          On the old UI, clicking either collection or shard did nothing. Something about the new impl made them clickable, but I obviously didn't take are about where they would point to. I'll take a look.

          Show
          upayavira Upayavira added a comment - Yikes. I don't think I ever clicked on those. Good catch. On the old UI, clicking either collection or shard did nothing. Something about the new impl made them clickable, but I obviously didn't take are about where they would point to. I'll take a look.
          Hide
          solrtrey Trey Grainger added a comment -

          Attached a patch which fixes this issue. The issue existed in both the flat graph view and the radial view. Additionally, when one was in the radial view and clicked on the link for a node, it would switch back to flat graph view when navigating to the other node, so fixed that so that it preserves the user's current view type on the URL when navigating between node.

          Show
          solrtrey Trey Grainger added a comment - Attached a patch which fixes this issue. The issue existed in both the flat graph view and the radial view. Additionally, when one was in the radial view and clicked on the link for a node, it would switch back to flat graph view when navigating to the other node, so fixed that so that it preserves the user's current view type on the URL when navigating between node.
          Hide
          githubbot ASF GitHub Bot added a comment -

          GitHub user treygrainger opened a pull request:

          https://github.com/apache/lucene-solr/pull/23

          SOLR-8626: Fix urls for nodes in cloud graph view

          This fixes SOLR-8626 (identical patch submitted on JIRA) by removing the invalid (404) links on collections and cores in the graph view. The issue existed - and has been fixed - in both the flat graph view and the radial view. Additionally, when one was in the radial view and clicked on the link for a node, it would switch back to flat graph view when navigating to the other node, so the patch also improves the link in the radial view so that it preserves the user's current view type on the URL when navigating between nodes.

          You can merge this pull request into a Git repository by running:

          $ git pull https://github.com/treygrainger/lucene-solr SOLR-8626

          Alternatively you can review and apply these changes as the patch at:

          https://github.com/apache/lucene-solr/pull/23.patch

          To close this pull request, make a commit to your master/trunk branch
          with (at least) the following in the commit message:

          This closes #23


          commit dc4a490eb4edf49972849eb42b604fe490a88d75
          Author: Trey Grainger <code@treygrainger.com>
          Date: 2016-03-20T04:21:16Z

          SOLR-8626: Fix urls for nodes in cloud graph view


          Show
          githubbot ASF GitHub Bot added a comment - GitHub user treygrainger opened a pull request: https://github.com/apache/lucene-solr/pull/23 SOLR-8626 : Fix urls for nodes in cloud graph view This fixes SOLR-8626 (identical patch submitted on JIRA) by removing the invalid (404) links on collections and cores in the graph view. The issue existed - and has been fixed - in both the flat graph view and the radial view. Additionally, when one was in the radial view and clicked on the link for a node, it would switch back to flat graph view when navigating to the other node, so the patch also improves the link in the radial view so that it preserves the user's current view type on the URL when navigating between nodes. You can merge this pull request into a Git repository by running: $ git pull https://github.com/treygrainger/lucene-solr SOLR-8626 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/lucene-solr/pull/23.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #23 commit dc4a490eb4edf49972849eb42b604fe490a88d75 Author: Trey Grainger <code@treygrainger.com> Date: 2016-03-20T04:21:16Z SOLR-8626 : Fix urls for nodes in cloud graph view
          Hide
          jira-bot ASF subversion and git services added a comment -

          Commit 9cbd54087ceafcc0eada370c9ce5bce05e1a462d in lucene-solr's branch refs/heads/master from Shalin Shekhar Mangar
          [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=9cbd540 ]

          SOLR-8626: 404 error when clicking nodes in cloud graph view in angular UI.

          This closes #23

          Show
          jira-bot ASF subversion and git services added a comment - Commit 9cbd54087ceafcc0eada370c9ce5bce05e1a462d in lucene-solr's branch refs/heads/master from Shalin Shekhar Mangar [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=9cbd540 ] SOLR-8626 : 404 error when clicking nodes in cloud graph view in angular UI. This closes #23
          Hide
          jira-bot ASF subversion and git services added a comment -

          Commit de85b9fff20cb63fd5096405adb5555521ac65ab in lucene-solr's branch refs/heads/branch_6x from Shalin Shekhar Mangar
          [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=de85b9f ]

          SOLR-8626: 404 error when clicking nodes in cloud graph view in angular UI.

          This closes #23
          (cherry picked from commit 9cbd540)

          Show
          jira-bot ASF subversion and git services added a comment - Commit de85b9fff20cb63fd5096405adb5555521ac65ab in lucene-solr's branch refs/heads/branch_6x from Shalin Shekhar Mangar [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=de85b9f ] SOLR-8626 : 404 error when clicking nodes in cloud graph view in angular UI. This closes #23 (cherry picked from commit 9cbd540)
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user asfgit closed the pull request at:

          https://github.com/apache/lucene-solr/pull/23

          Show
          githubbot ASF GitHub Bot added a comment - Github user asfgit closed the pull request at: https://github.com/apache/lucene-solr/pull/23
          Hide
          shalinmangar Shalin Shekhar Mangar added a comment -

          Thanks Jan and Trey!

          Show
          shalinmangar Shalin Shekhar Mangar added a comment - Thanks Jan and Trey!
          Hide
          mikemccand Michael McCandless added a comment -

          Bulk close resolved issues after 6.2.0 release.

          Show
          mikemccand Michael McCandless added a comment - Bulk close resolved issues after 6.2.0 release.

            People

            • Assignee:
              shalinmangar Shalin Shekhar Mangar
              Reporter:
              janhoy Jan Høydahl
            • Votes:
              0 Vote for this issue
              Watchers:
              8 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development