[SOLR-8611] Incorrect logging in ZkController

• Type: Bug
• Status: Open
• Priority: Minor
• Resolution: Unresolved
• Affects Version/s: 5.4
• Component/s: SolrCloud
• Labels: logging
• Assignee: Unassigned
• Reporter: Stephan Lagraulet
• Created: 28/Jan/16 11:44
• Updated: 28/Sep/16 11:31

Description

When a new Zookeeper Session is created all cores publish a "down" status.
Then a call to "waitForLeaderToSeeDownState" is made.
Unfortunately, the logged info inside this method is not correct, keeping the last published core:

2016-01-28 10:19:36.296 INFO  (zkCallback-3-thread-37-processing-n:node054:8983_solr) [   ] o.a.s.c.ZkController ZooKeeper session re-connected ... refreshing core states after session expiration.
2016-01-28 10:19:36.296 INFO  (zkCallback-3-thread-37-processing-n:node054:8983_solr) [c:offers_suggest_marketing s:shard1 r:core_node3 x:offers_suggest_marketing_shard1_replica5] o.a.s.c.ZkController publishing state=down
2016-01-28 10:19:36.300 INFO  (zkCallback-3-thread-37-processing-n:node054:8983_solr) [c:offers_suggest_topsearch s:shard1 r:core_node4 x:offers_suggest_topsearch_shard1_replica2] o.a.s.c.ZkController publishing state=down
2016-01-28 10:19:36.301 INFO  (zkCallback-3-thread-37-processing-n:node054:8983_solr) [c:offers_storage s:shard3 r:core_node8 x:offers_storage_shard3_replica2] o.a.s.c.ZkController publishing state=down
2016-01-28 10:19:36.302 INFO  (zkCallback-3-thread-37-processing-n:node054:8983_solr) [c:offers_lean s:shard3 r:core_node6 x:offers_lean_shard3_replica2] o.a.s.c.ZkController publishing state=down
2016-01-28 10:19:36.305 INFO  (zkCallback-3-thread-37-processing-n:node054:8983_solr) [c:offers_lean s:shard3 r:core_node6 x:offers_lean_shard3_replica2] o.a.s.c.ZkController Replica core_node3 NOT in leader-initiated recovery, need to wait for leader to see down state.
2016-01-28 10:19:36.313 INFO  (zkCallback-3-thread-37-processing-n:node054:8983_solr) [c:offers_lean s:shard3 r:core_node6 x:offers_lean_shard3_replica2] o.a.s.c.ZkController Replica core_node4 NOT in leader-initiated recovery, need to wait for leader to see down state.
2016-01-28 10:19:36.317 INFO  (zkCallback-3-thread-37-processing-n:node054:8983_solr) [c:offers_lean s:shard3 r:core_node6 x:offers_lean_shard3_replica2] o.a.s.c.ZkController Replica core_node8 NOT in leader-initiated recovery, need to wait for leader to see down state.

It should be

2016-01-28 10:19:36.296 INFO  (zkCallback-3-thread-37-processing-n:node054:8983_solr) [   ] o.a.s.c.ZkController ZooKeeper session re-connected ... refreshing core states after session expiration.
2016-01-28 10:19:36.296 INFO  (zkCallback-3-thread-37-processing-n:node054:8983_solr) [c:offers_suggest_marketing s:shard1 r:core_node3 x:offers_suggest_marketing_shard1_replica5] o.a.s.c.ZkController publishing state=down
2016-01-28 10:19:36.300 INFO  (zkCallback-3-thread-37-processing-n:node054:8983_solr) [c:offers_suggest_topsearch s:shard1 r:core_node4 x:offers_suggest_topsearch_shard1_replica2] o.a.s.c.ZkController publishing state=down
2016-01-28 10:19:36.301 INFO  (zkCallback-3-thread-37-processing-n:node054:8983_solr) [c:offers_storage s:shard3 r:core_node8 x:offers_storage_shard3_replica2] o.a.s.c.ZkController publishing state=down
2016-01-28 10:19:36.302 INFO  (zkCallback-3-thread-37-processing-n:node054:8983_solr) [c:offers_lean s:shard3 r:core_node6 x:offers_lean_shard3_replica2] o.a.s.c.ZkController publishing state=down
2016-01-28 10:19:36.305 INFO  (zkCallback-3-thread-37-processing-n:node054:8983_solr) [c:offers_suggest_marketing s:shard1 r:core_node3 x:offers_suggest_marketing_shard1_replica5] o.a.s.c.ZkController Replica core_node3 NOT in leader-initiated recovery, need to wait for leader to see down state.
2016-01-28 10:19:36.313 INFO  (zkCallback-3-thread-37-processing-n:node054:8983_solr) [c:offers_suggest_topsearch s:shard1 r:core_node4 x:offers_suggest_topsearch_shard1_replica2] o.a.s.c.ZkController Replica core_node4 NOT in leader-initiated recovery, need to wait for leader to see down state.
2016-01-28 10:19:36.317 INFO  (zkCallback-3-thread-37-processing-n:node054:8983_solr) [c:offers_storage s:shard3 r:core_node8 x:offers_storage_shard3_replica2] o.a.s.c.ZkController Replica core_node8 NOT in leader-initiated recovery, need to wait for leader to see down state.