Solr
  1. Solr
  2. SOLR-8595

Use BinaryRequestWriter by default in HttpSolrClient and ConcurrentUpdateSolrClient

    Details

    • Type: Improvement Improvement
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 5.5, 6.0
    • Component/s: SolrJ
    • Labels:
      None

      Description

      Use BinaryRequestWriter by default in HttpSolrClient and ConcurrentUpdateSolrClient. They both use xml based update format right now.

      1. SOLR-8595.patch
        3 kB
        Shalin Shekhar Mangar
      2. SOLR-8595.patch
        2 kB
        Shalin Shekhar Mangar

        Issue Links

          Activity

          Hide
          Shalin Shekhar Mangar added a comment -

          Trivial patch. ConcurrentUpdateSolrClient uses HttpSolrClient so changing the default in HttpSolrClient is sufficient.

          Show
          Shalin Shekhar Mangar added a comment - Trivial patch. ConcurrentUpdateSolrClient uses HttpSolrClient so changing the default in HttpSolrClient is sufficient.
          Hide
          David Smiley added a comment -

          +1.

          Side note (separate issue): It'd be nice if there was a SolrServer one-liner to set all communication (req & rsp) to be XML or binary as a toggle, without having to know which classes to the parsing/writing as that's really an implementation/internal detail. It's nice to make such a flag configurable in the client's software to ease upgrades.

          Show
          David Smiley added a comment - +1. Side note (separate issue): It'd be nice if there was a SolrServer one-liner to set all communication (req & rsp) to be XML or binary as a toggle, without having to know which classes to the parsing/writing as that's really an implementation/internal detail. It's nice to make such a flag configurable in the client's software to ease upgrades.
          Hide
          Shalin Shekhar Mangar added a comment -

          Fixes a test failure in BasicHttpSolrClientTest.testUpdate which made assumptions about the default update content type

          Show
          Shalin Shekhar Mangar added a comment - Fixes a test failure in BasicHttpSolrClientTest.testUpdate which made assumptions about the default update content type
          Hide
          ASF subversion and git services added a comment -

          Commit 6acfa2a4ffb1e5ac0973ac484e9cf8452b4b23d3 in lucene-solr's branch refs/heads/master from Shalin Shekhar Mangar
          [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=6acfa2a ]

          SOLR-8595: Use BinaryRequestWriter by default in HttpSolrClient and ConcurrentUpdateSolrClient

          Show
          ASF subversion and git services added a comment - Commit 6acfa2a4ffb1e5ac0973ac484e9cf8452b4b23d3 in lucene-solr's branch refs/heads/master from Shalin Shekhar Mangar [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=6acfa2a ] SOLR-8595 : Use BinaryRequestWriter by default in HttpSolrClient and ConcurrentUpdateSolrClient
          Hide
          ASF subversion and git services added a comment -

          Commit d6ead3b930e56e7c170baadd63f81135f29ee072 in lucene-solr's branch refs/heads/branch_5x from Shalin Shekhar Mangar
          [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=d6ead3b ]

          SOLR-8595: Use BinaryRequestWriter by default in HttpSolrClient and ConcurrentUpdateSolrClient
          (cherry picked from commit 6acfa2a)

          Show
          ASF subversion and git services added a comment - Commit d6ead3b930e56e7c170baadd63f81135f29ee072 in lucene-solr's branch refs/heads/branch_5x from Shalin Shekhar Mangar [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=d6ead3b ] SOLR-8595 : Use BinaryRequestWriter by default in HttpSolrClient and ConcurrentUpdateSolrClient (cherry picked from commit 6acfa2a)
          Hide
          Shalin Shekhar Mangar added a comment -

          Thanks for the +1 David. Please feel free to open another issue for the binary vs xml methods.

          Show
          Shalin Shekhar Mangar added a comment - Thanks for the +1 David. Please feel free to open another issue for the binary vs xml methods.

            People

            • Assignee:
              Shalin Shekhar Mangar
              Reporter:
              Shalin Shekhar Mangar
            • Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development