Uploaded image for project: 'Solr'
  1. Solr
  2. SOLR-8565

add & use CommonParams.(ROWS|START)_DEFAULT constant

    Details

    • Type: Task
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 5.5, 6.0
    • Component/s: None
    • Labels:
      None

      Description

      • add & use CommonParams.ROWS_DEFAULT constant (instead of 10)
      • add & use CommonParams.START_DEFAULT (instead of 0)
      • add CommonParamsTest test (initially only with test(Start|Rows)[Default] methods)

      This will make it easier to understand what value is used if the "rows" parameter is omitted, and in the case of the "start" parameter it makes the 0-or-1 question go away.

      The newly added CommonParamsTest methods are to ensure accidental (or intentional) changes to the (default) constants are caught by a test.

        Attachments

        1. SOLR-8565.patch
          6 kB
          Christine Poerschke

          Activity

            People

            • Assignee:
              cpoerschke Christine Poerschke
              Reporter:
              cpoerschke Christine Poerschke
            • Votes:
              1 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: