Solr
  1. Solr
  2. SOLR-8565

add & use CommonParams.(ROWS|START)_DEFAULT constant

    Details

    • Type: Task Task
    • Status: Closed
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 5.5, 6.0
    • Component/s: None
    • Labels:
      None

      Description

      • add & use CommonParams.ROWS_DEFAULT constant (instead of 10)
      • add & use CommonParams.START_DEFAULT (instead of 0)
      • add CommonParamsTest test (initially only with test(Start|Rows)[Default] methods)

      This will make it easier to understand what value is used if the "rows" parameter is omitted, and in the case of the "start" parameter it makes the 0-or-1 question go away.

      The newly added CommonParamsTest methods are to ensure accidental (or intentional) changes to the (default) constants are caught by a test.

      1. SOLR-8565.patch
        6 kB
        Christine Poerschke

        Activity

        Hide
        Christine Poerschke added a comment -

        Attaching proposed patch against trunk.

        Show
        Christine Poerschke added a comment - Attaching proposed patch against trunk.
        Hide
        ASF subversion and git services added a comment -

        Commit 1725708 from Christine Poerschke in branch 'dev/trunk'
        [ https://svn.apache.org/r1725708 ]

        SOLR-8565: add & use CommonParams.(ROWS|START)_DEFAULT constants, add CommonParamsTest

        Show
        ASF subversion and git services added a comment - Commit 1725708 from Christine Poerschke in branch 'dev/trunk' [ https://svn.apache.org/r1725708 ] SOLR-8565 : add & use CommonParams.(ROWS|START)_DEFAULT constants, add CommonParamsTest
        Hide
        ASF subversion and git services added a comment -

        Commit 1725711 from Christine Poerschke in branch 'dev/branches/branch_5x'
        [ https://svn.apache.org/r1725711 ]

        SOLR-8565: add & use CommonParams.(ROWS|START)_DEFAULT constants, add CommonParamsTest (merge in revision 1725708 from trunk)

        Show
        ASF subversion and git services added a comment - Commit 1725711 from Christine Poerschke in branch 'dev/branches/branch_5x' [ https://svn.apache.org/r1725711 ] SOLR-8565 : add & use CommonParams.(ROWS|START)_DEFAULT constants, add CommonParamsTest (merge in revision 1725708 from trunk)

          People

          • Assignee:
            Christine Poerschke
            Reporter:
            Christine Poerschke
          • Votes:
            1 Vote for this issue
            Watchers:
            3 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development