Uploaded image for project: 'Solr'
  1. Solr
  2. SOLR-8529

Improve JdbcTest to not use plain assert statements

        Details

        • Type: Improvement
        • Status: Resolved
        • Priority: Major
        • Resolution: Implemented
        • Affects Version/s: 6.0
        • Fix Version/s: None
        • Component/s: SolrJ
        • Labels:
          None
        • Flags:
          Patch

          Description

          Plain assert statements work but it makes debugging hard. Instead should use assertEquals, etc.

          1. Text File
            SOLR-8529.patch
            15 kB
            Kevin Risden
          2. Text File
            SOLR-8529.patch
            15 kB
            Kevin Risden
          3. Text File
            SOLR-8529.patch
            14 kB
            Kevin Risden
          4. Text File
            SOLR-8529.patch
            10 kB
            Kevin Risden

            Issue Links

            depends upon

            Improvement - An improvement or enhancement to an existing feature or task. SOLR-8527 Improve JdbcTest to cleanup properly on failures

            • Major - Major loss of function.
            • Resolved
            relates to

            New Feature - A new feature of the product, which has yet to be developed. SOLR-8125 Umbrella ticket for Streaming and SQL issues

            • Major - Major loss of function.
            • Open

            Improvement - An improvement or enhancement to an existing feature or task. SOLR-8608 Improve SolrJ JDBC testing

            • Major - Major loss of function.
            • Open

              Activity

              Ascending order - Click to sort in descending order
              Hide
              Permalink
              risdenk Kevin Risden added a comment -

              Builds upon improvements from SOLR-8527.

              Show
              risdenk Kevin Risden added a comment - Builds upon improvements from SOLR-8527 .
              Hide
              Permalink
              risdenk Kevin Risden added a comment -

              Changes assert statements to assertTrue, assertFalse, and assertEquals as appropriate.

              Show
              risdenk Kevin Risden added a comment - Changes assert statements to assertTrue, assertFalse, and assertEquals as appropriate.
              Hide
              Permalink
              risdenk Kevin Risden added a comment -

              Updated to master.

              Show
              risdenk Kevin Risden added a comment - Updated to master.
              Hide
              Permalink
              risdenk Kevin Risden added a comment -

              Based on top of SOLR-8527

              Show
              risdenk Kevin Risden added a comment - Based on top of SOLR-8527
              Hide
              Permalink
              risdenk Kevin Risden added a comment -

              Rebased on top of updated SOLR-8527. This uses assert* instead of plain asserts in the tests.

              Joel Bernstein - Can you take a look at this patch after SOLR-8527?

              Show
              risdenk Kevin Risden added a comment - Rebased on top of updated SOLR-8527 . This uses assert* instead of plain asserts in the tests. Joel Bernstein - Can you take a look at this patch after SOLR-8527 ?
              Hide
              Permalink
              joel.bernstein Joel Bernstein added a comment -

              Yep, I'll also look at this today.

              Show
              joel.bernstein Joel Bernstein added a comment - Yep, I'll also look at this today.
              Hide
              Permalink
              jira-bot ASF subversion and git services added a comment -

              Commit 111f45efa91392eaea55a590b0d5c84697f6fd7f in lucene-solr's branch refs/heads/master from jbernste
              [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=111f45e ]

              SOLR-8529: Improve JdbcTest to not use plain assert statements

              Show
              jira-bot ASF subversion and git services added a comment - Commit 111f45efa91392eaea55a590b0d5c84697f6fd7f in lucene-solr's branch refs/heads/master from jbernste [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=111f45e ] SOLR-8529 : Improve JdbcTest to not use plain assert statements

                People

                • Assignee:
                  Unassigned
                  Reporter:
                  risdenk Kevin Risden
                • Votes:
                  0 Vote for this issue
                  Watchers:
                  3 Start watching this issue

                  Dates

                  • Created:
                    Updated:
                    Resolved:

                    Development