Uploaded image for project: 'Solr'
  1. Solr
  2. SOLR-8527

Improve JdbcTest to cleanup properly on failures

    Details

    • Type: Improvement
    • Status: Resolved
    • Priority: Major
    • Resolution: Implemented
    • Affects Version/s: 6.0
    • Fix Version/s: None
    • Component/s: SolrJ
    • Labels:
      None
    • Flags:
      Patch

      Description

      Currently if a test case fails in JdbcTest then resources are not closed properly.

      1. SOLR-8527.patch
        14 kB
        Kevin Risden
      2. SOLR-8527.patch
        18 kB
        Kevin Risden
      3. SOLR-8527.patch
        18 kB
        Kevin Risden

        Issue Links

          Activity

          Hide
          risdenk Kevin Risden added a comment -

          This patch uses try-with-resources on the JDBC connections, statements, and resultsets. The diff looks a lot better in IntelliJ ignoring the whitespace changes in front of the assert statements.

          Show
          risdenk Kevin Risden added a comment - This patch uses try-with-resources on the JDBC connections, statements, and resultsets. The diff looks a lot better in IntelliJ ignoring the whitespace changes in front of the assert statements.
          Hide
          risdenk Kevin Risden added a comment -

          rebased on master.

          Show
          risdenk Kevin Risden added a comment - rebased on master.
          Hide
          risdenk Kevin Risden added a comment -

          Added latest patch based on master. Uses try-with-resources around the JdbcTest connections, statements, and resultsets.

          Joel Bernstein - Can you review when you get a chance?

          Show
          risdenk Kevin Risden added a comment - Added latest patch based on master. Uses try-with-resources around the JdbcTest connections, statements, and resultsets. Joel Bernstein - Can you review when you get a chance?
          Hide
          joel.bernstein Joel Bernstein added a comment -

          I take a look at this today.

          Show
          joel.bernstein Joel Bernstein added a comment - I take a look at this today.
          Hide
          jira-bot ASF subversion and git services added a comment -

          Commit 56b79ece8b3c670b936792759aed9d0bb5e3eb7f in lucene-solr's branch refs/heads/master from jbernste
          [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=56b79ec ]

          SOLR-8527: Improve JdbcTest to cleanup properly on failures

          Show
          jira-bot ASF subversion and git services added a comment - Commit 56b79ece8b3c670b936792759aed9d0bb5e3eb7f in lucene-solr's branch refs/heads/master from jbernste [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=56b79ec ] SOLR-8527 : Improve JdbcTest to cleanup properly on failures

            People

            • Assignee:
              Unassigned
              Reporter:
              risdenk Kevin Risden
            • Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development