Uploaded image for project: 'Solr'
  1. Solr
  2. SOLR-8475 Some refactoring to SolrIndexSearcher
  3. SOLR-8490

factor out a QueryCommand (super) class from SolrIndexSearcher.QueryCommand

    XMLWordPrintableJSON

    Details

    • Type: Sub-task
    • Status: Closed
    • Priority: Minor
    • Resolution: Won't Fix
    • Affects Version/s: None
    • Fix Version/s: 5.5, 6.0
    • Component/s: search
    • Labels:
      None

      Description

      part 0 (for trunk and branch_5x) - preparation:

      • two minor changes in QueryComponent.java and SolrIndexSearcher.java to simplify the subsequent actual changes

      part 1 (for trunk and branch_5x) - factor out a QueryCommand (super) class from SolrIndexSearcher.QueryCommand:

      • for back-compat reasons SolrIndexSearcher.QueryCommand inherits from the factored out class
      • for private variables and methods use QueryCommand instead of SolrIndexSearcher.QueryCommand
      • public methods and constructors taking SolrIndexSearcher.QueryCommand args marked @Deprecated and equivalents with QueryCommand arg created

      part 2 (for trunk only) - remove deprecated SolrIndexSearcher.QueryCommand class:

      • affected/changed public or protected methods:
        • ResponseBuilder.getQueryCommand()
        • SolrIndexSearcher.search(QueryResult qr, QueryCommand cmd)
        • SolrIndexSearcher.sortDocSet(QueryResult qr, QueryCommand cmd)

        Attachments

        1. SOLR-8490-part2.patch
          13 kB
          Christine Poerschke
        2. SOLR-8490-part1.patch
          21 kB
          Christine Poerschke
        3. SOLR-8490-part0.patch
          2 kB
          Christine Poerschke

          Activity

            People

            • Assignee:
              cpoerschke Christine Poerschke
              Reporter:
              cpoerschke Christine Poerschke
            • Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: