Solr
  1. Solr
  2. SOLR-8483

tweak open-exchange-rates.json test-file to avoid OpenExchangeRatesOrgProvider.java warnings

    Details

    • Type: Test Test
    • Status: Closed
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 5.5, 6.0
    • Component/s: None
    • Labels:
      None

      Description

      Tweak the open-exchange-rates.json test file so that OpenExchangeRatesOrgProvider does not emit 'Unknown key IMPORTANT NOTE' and 'Expected key, got STRING' warnings which can be confusing when investigating unrelated test failures.

      1. SOLR-8483.patch
        1 kB
        Christine Poerschke

        Activity

        Hide
        Christine Poerschke added a comment -

        Proposed test file patch against trunk. The important note is preserved but is no longer a JSON element by itself (which OpenExchangeRatesOrgProvider.java would warn about) but simply appended to the "This data is not real ... " disclaimer JSON element.

        Show
        Christine Poerschke added a comment - Proposed test file patch against trunk. The important note is preserved but is no longer a JSON element by itself (which OpenExchangeRatesOrgProvider.java would warn about) but simply appended to the "This data is not real ... " disclaimer JSON element.
        Hide
        ASF subversion and git services added a comment -

        Commit 1723040 from Christine Poerschke in branch 'dev/trunk'
        [ https://svn.apache.org/r1723040 ]

        SOLR-8483: relocate 'IMPORTANT NOTE' in open-exchange-rates.json test-file to avoid OpenExchangeRatesOrgProvider.java warnings.

        Show
        ASF subversion and git services added a comment - Commit 1723040 from Christine Poerschke in branch 'dev/trunk' [ https://svn.apache.org/r1723040 ] SOLR-8483 : relocate 'IMPORTANT NOTE' in open-exchange-rates.json test-file to avoid OpenExchangeRatesOrgProvider.java warnings.
        Hide
        ASF subversion and git services added a comment -

        Commit 1723057 from Christine Poerschke in branch 'dev/branches/branch_5x'
        [ https://svn.apache.org/r1723057 ]

        SOLR-8483: relocate 'IMPORTANT NOTE' in open-exchange-rates.json test-file to avoid OpenExchangeRatesOrgProvider.java warnings. (merge in revision 1723040 from trunk)

        Show
        ASF subversion and git services added a comment - Commit 1723057 from Christine Poerschke in branch 'dev/branches/branch_5x' [ https://svn.apache.org/r1723057 ] SOLR-8483 : relocate 'IMPORTANT NOTE' in open-exchange-rates.json test-file to avoid OpenExchangeRatesOrgProvider.java warnings. (merge in revision 1723040 from trunk)

          People

          • Assignee:
            Christine Poerschke
            Reporter:
            Christine Poerschke
          • Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development