CoreAdminHandler is too large and unmanageable. Split it and make it simpler
Commit 1722738 from Noble Paul in branch 'dev/trunk'
[ https://svn.apache.org/r1722738 ]
SOLR-8476: Refactor and cleanup CoreAdminHandler
Commit 1722787 from Noble Paul in branch 'dev/branches/branch_5x'
[ https://svn.apache.org/r1722787 ]
Commit 1722788 from Noble Paul in branch 'dev/trunk'
[ https://svn.apache.org/r1722788 ]
Doesn't this break compatibility? We have allowed people to plugin their custom CoreAdminHandler until now and suddenly the "other" methods such as create or reload are no longer available in the sub-classes.
Perhaps this should be trunk only and mentioned in the upgrading section?
I don't think users should implement anything other than handleCustomAction() (that is still possible).
They still can override handleRequestBody() if required.
Commit 1722791 from Noble Paul in branch 'dev/branches/branch_5x'
[ https://svn.apache.org/r1722791 ]
The other methods weren't marked as lucene.experimental so they are public API and this is a break in compatibility. All I am asking is that this should be called out in the upgrading section.
sure, I'll add this to the upgrading section
Seems like you missed setting svn eol-style on the new file.
I'll do that.
Commit 1722862 from Anshum Gupta in branch 'dev/branches/branch_5x'
[ https://svn.apache.org/r1722862 ]
SOLR-8476: adding svn:eol-style property for CoreAdminOperation.java
Commit 1722884 from Noble Paul in branch 'dev/trunk'
[ https://svn.apache.org/r1722884 ]
SOLR-8476: Refactored CoreAdminHandler
Commit 1722885 from Noble Paul in branch 'dev/branches/branch_5x'
[ https://svn.apache.org/r1722885 ]
admin UI not working properly
Commit 1722900 from Noble Paul in branch 'dev/trunk'
[ https://svn.apache.org/r1722900 ]
SOLR-8476: COreAdminHandler refactoring
Commit 1722901 from Noble Paul in branch 'dev/branches/branch_5x'
[ https://svn.apache.org/r1722901 ]
SOLR-8476: CoreAdminHandler refactoring
Hi Noble Paul,
What do you think about removing the unused commands from the CoreAdmin?
I also removed the persist operation as all it was returning was an error message that it had been deprecated and no action
Removes some more unused constants
go ahead Varun Thacker
Oh my. I would have taken great pleasure in getting rid of persist had I thought about it. That was such a mess to try to keep working in the old solr.xml format.
I suspect Alan Woodward is dancing a little dance at this final remnant being gone too
Updated patch . Removing the PERSIST should be fine from SolrJ in terms of back-compat right? It didn't have action anyways and has been deprecated since a long time ( Solr 4.5 via SOLR-4914 )
Hi Erick/Noble ,
Any comments on my last patch? All tests pass and I'll like to commit it soon
👍 Varun Thacker
Commit 1724074 from Varun Thacker in branch 'dev/trunk'
[ https://svn.apache.org/r1724074 ]
SOLR-8476: Removed Persist action and minor cleanups to CoreAdminHandlerm also moved the CHANGES entry to the correct section
Commit 1724081 from Varun Thacker in branch 'dev/branches/branch_5x'
[ https://svn.apache.org/r1724081 ]
SOLR-8476: Removed Persist action and minor cleanups to CoreAdminHandler (merged trunk r1724074)