Solr
  1. Solr
  2. SOLR-8476

Refactor and cleanup CoreAdminHandler

    Details

    • Type: Task Task
    • Status: Closed
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 5.5, 6.0
    • Component/s: None
    • Labels:
      None

      Description

      CoreAdminHandler is too large and unmanageable. Split it and make it simpler

      1. SOLR-8476.patch
        6 kB
        Varun Thacker
      2. SOLR-8476.patch
        5 kB
        Varun Thacker
      3. SOLR-8476.patch
        3 kB
        Varun Thacker
      4. SOLR-8476.patch
        85 kB
        Noble Paul

        Activity

        Hide
        ASF subversion and git services added a comment -

        Commit 1722738 from Noble Paul in branch 'dev/trunk'
        [ https://svn.apache.org/r1722738 ]

        SOLR-8476: Refactor and cleanup CoreAdminHandler

        Show
        ASF subversion and git services added a comment - Commit 1722738 from Noble Paul in branch 'dev/trunk' [ https://svn.apache.org/r1722738 ] SOLR-8476 : Refactor and cleanup CoreAdminHandler
        Hide
        ASF subversion and git services added a comment -

        Commit 1722787 from Noble Paul in branch 'dev/branches/branch_5x'
        [ https://svn.apache.org/r1722787 ]

        SOLR-8476: Refactor and cleanup CoreAdminHandler

        Show
        ASF subversion and git services added a comment - Commit 1722787 from Noble Paul in branch 'dev/branches/branch_5x' [ https://svn.apache.org/r1722787 ] SOLR-8476 : Refactor and cleanup CoreAdminHandler
        Hide
        ASF subversion and git services added a comment -

        Commit 1722788 from Noble Paul in branch 'dev/trunk'
        [ https://svn.apache.org/r1722788 ]

        SOLR-8476: Refactor and cleanup CoreAdminHandler

        Show
        ASF subversion and git services added a comment - Commit 1722788 from Noble Paul in branch 'dev/trunk' [ https://svn.apache.org/r1722788 ] SOLR-8476 : Refactor and cleanup CoreAdminHandler
        Hide
        Shalin Shekhar Mangar added a comment -

        Doesn't this break compatibility? We have allowed people to plugin their custom CoreAdminHandler until now and suddenly the "other" methods such as create or reload are no longer available in the sub-classes.

        Perhaps this should be trunk only and mentioned in the upgrading section?

        Show
        Shalin Shekhar Mangar added a comment - Doesn't this break compatibility? We have allowed people to plugin their custom CoreAdminHandler until now and suddenly the "other" methods such as create or reload are no longer available in the sub-classes. Perhaps this should be trunk only and mentioned in the upgrading section?
        Hide
        Noble Paul added a comment - - edited

        I don't think users should implement anything other than handleCustomAction() (that is still possible).

        They still can override handleRequestBody() if required.

        Show
        Noble Paul added a comment - - edited I don't think users should implement anything other than handleCustomAction() (that is still possible). They still can override handleRequestBody() if required.
        Hide
        ASF subversion and git services added a comment -

        Commit 1722791 from Noble Paul in branch 'dev/branches/branch_5x'
        [ https://svn.apache.org/r1722791 ]

        SOLR-8476: Refactor and cleanup CoreAdminHandler

        Show
        ASF subversion and git services added a comment - Commit 1722791 from Noble Paul in branch 'dev/branches/branch_5x' [ https://svn.apache.org/r1722791 ] SOLR-8476 : Refactor and cleanup CoreAdminHandler
        Hide
        Shalin Shekhar Mangar added a comment -

        The other methods weren't marked as lucene.experimental so they are public API and this is a break in compatibility. All I am asking is that this should be called out in the upgrading section.

        Show
        Shalin Shekhar Mangar added a comment - The other methods weren't marked as lucene.experimental so they are public API and this is a break in compatibility. All I am asking is that this should be called out in the upgrading section.
        Hide
        Noble Paul added a comment -

        sure, I'll add this to the upgrading section

        Show
        Noble Paul added a comment - sure, I'll add this to the upgrading section
        Hide
        Anshum Gupta added a comment -

        Seems like you missed setting svn eol-style on the new file.
        I'll do that.

        Show
        Anshum Gupta added a comment - Seems like you missed setting svn eol-style on the new file. I'll do that.
        Hide
        ASF subversion and git services added a comment -

        Commit 1722862 from Anshum Gupta in branch 'dev/branches/branch_5x'
        [ https://svn.apache.org/r1722862 ]

        SOLR-8476: adding svn:eol-style property for CoreAdminOperation.java

        Show
        ASF subversion and git services added a comment - Commit 1722862 from Anshum Gupta in branch 'dev/branches/branch_5x' [ https://svn.apache.org/r1722862 ] SOLR-8476 : adding svn:eol-style property for CoreAdminOperation.java
        Hide
        ASF subversion and git services added a comment -

        Commit 1722884 from Noble Paul in branch 'dev/trunk'
        [ https://svn.apache.org/r1722884 ]

        SOLR-8476: Refactored CoreAdminHandler

        Show
        ASF subversion and git services added a comment - Commit 1722884 from Noble Paul in branch 'dev/trunk' [ https://svn.apache.org/r1722884 ] SOLR-8476 : Refactored CoreAdminHandler
        Hide
        ASF subversion and git services added a comment -

        Commit 1722885 from Noble Paul in branch 'dev/branches/branch_5x'
        [ https://svn.apache.org/r1722885 ]

        SOLR-8476: Refactored CoreAdminHandler

        Show
        ASF subversion and git services added a comment - Commit 1722885 from Noble Paul in branch 'dev/branches/branch_5x' [ https://svn.apache.org/r1722885 ] SOLR-8476 : Refactored CoreAdminHandler
        Hide
        Noble Paul added a comment -

        admin UI not working properly

        Show
        Noble Paul added a comment - admin UI not working properly
        Hide
        ASF subversion and git services added a comment -

        Commit 1722900 from Noble Paul in branch 'dev/trunk'
        [ https://svn.apache.org/r1722900 ]

        SOLR-8476: COreAdminHandler refactoring

        Show
        ASF subversion and git services added a comment - Commit 1722900 from Noble Paul in branch 'dev/trunk' [ https://svn.apache.org/r1722900 ] SOLR-8476 : COreAdminHandler refactoring
        Hide
        ASF subversion and git services added a comment -

        Commit 1722901 from Noble Paul in branch 'dev/branches/branch_5x'
        [ https://svn.apache.org/r1722901 ]

        SOLR-8476: CoreAdminHandler refactoring

        Show
        ASF subversion and git services added a comment - Commit 1722901 from Noble Paul in branch 'dev/branches/branch_5x' [ https://svn.apache.org/r1722901 ] SOLR-8476 : CoreAdminHandler refactoring
        Hide
        Varun Thacker added a comment -

        Hi Noble Paul,

        What do you think about removing the unused commands from the CoreAdmin?

        I also removed the persist operation as all it was returning was an error message that it had been deprecated and no action

        Show
        Varun Thacker added a comment - Hi Noble Paul , What do you think about removing the unused commands from the CoreAdmin? I also removed the persist operation as all it was returning was an error message that it had been deprecated and no action
        Hide
        Varun Thacker added a comment -

        Removes some more unused constants

        Show
        Varun Thacker added a comment - Removes some more unused constants
        Hide
        Noble Paul added a comment -

        go ahead Varun Thacker

        Show
        Noble Paul added a comment - go ahead Varun Thacker
        Hide
        Erick Erickson added a comment -

        Oh my. I would have taken great pleasure in getting rid of persist had I thought about it. That was such a mess to try to keep working in the old solr.xml format.

        I suspect Alan Woodward is dancing a little dance at this final remnant being gone too

        Show
        Erick Erickson added a comment - Oh my. I would have taken great pleasure in getting rid of persist had I thought about it. That was such a mess to try to keep working in the old solr.xml format. I suspect Alan Woodward is dancing a little dance at this final remnant being gone too
        Hide
        Varun Thacker added a comment -

        Updated patch . Removing the PERSIST should be fine from SolrJ in terms of back-compat right? It didn't have action anyways and has been deprecated since a long time ( Solr 4.5 via SOLR-4914 )

        Show
        Varun Thacker added a comment - Updated patch . Removing the PERSIST should be fine from SolrJ in terms of back-compat right? It didn't have action anyways and has been deprecated since a long time ( Solr 4.5 via SOLR-4914 )
        Hide
        Varun Thacker added a comment -

        Hi Erick/Noble ,

        Any comments on my last patch? All tests pass and I'll like to commit it soon

        Show
        Varun Thacker added a comment - Hi Erick/Noble , Any comments on my last patch? All tests pass and I'll like to commit it soon
        Hide
        Noble Paul added a comment -

        ๐Ÿ‘ Varun Thacker

        Show
        Noble Paul added a comment - ๐Ÿ‘ Varun Thacker
        Hide
        ASF subversion and git services added a comment -

        Commit 1724074 from Varun Thacker in branch 'dev/trunk'
        [ https://svn.apache.org/r1724074 ]

        SOLR-8476: Removed Persist action and minor cleanups to CoreAdminHandlerm also moved the CHANGES entry to the correct section

        Show
        ASF subversion and git services added a comment - Commit 1724074 from Varun Thacker in branch 'dev/trunk' [ https://svn.apache.org/r1724074 ] SOLR-8476 : Removed Persist action and minor cleanups to CoreAdminHandlerm also moved the CHANGES entry to the correct section
        Hide
        ASF subversion and git services added a comment -

        Commit 1724081 from Varun Thacker in branch 'dev/branches/branch_5x'
        [ https://svn.apache.org/r1724081 ]

        SOLR-8476: Removed Persist action and minor cleanups to CoreAdminHandler (merged trunk r1724074)

        Show
        ASF subversion and git services added a comment - Commit 1724081 from Varun Thacker in branch 'dev/branches/branch_5x' [ https://svn.apache.org/r1724081 ] SOLR-8476 : Removed Persist action and minor cleanups to CoreAdminHandler (merged trunk r1724074)

          People

          • Assignee:
            Noble Paul
            Reporter:
            Noble Paul
          • Votes:
            0 Vote for this issue
            Watchers:
            7 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development