[SOLR-8475] Some refactoring to SolrIndexSearcher

• Type: Improvement
• Status: Resolved
• Priority: Minor
• Resolution: Fixed
• Fix Version/s: 6.0
• Component/s: search
• Assignee: Shai Erera
• Reporter: Shai Erera
• Created: 30/Dec/15 11:54
• Updated: 09/May/16 18:50
• Resolved: 10/Jan/16 08:33

Description

While reviewing SolrIndexSearcher, I started to correct a thing here and there, and eventually it led to these changes:

• Moving QueryCommand and QueryResult to their own classes.
• Moving FilterImpl into a private static class (was package-private and defined in the same .java file, but separate class).
• Some code formatting, imports organizing and minor log changes.
• Removed fieldNames (handled the TODO in the code)
• Got rid of usage of deprecated classes such as LegacyNumericUtils and Legacy-*-Field.

I wish we'd cut down the size of this file much more (it's 2500 lines now), but I've decided to stop here so that the patch is manageable. I would like to explore further refactorings afterwards, e.g. extracting cache management code to an outer class (but keep SolrIndexSearcher's API the same, if possible).

If you have additional ideas of more cleanups / simplifications, I'd be glad to do them.

Sub-Tasks

• factor out a QueryCommand (super) class from SolrIndexSearcher.QueryCommand: Closed