Uploaded image for project: 'Solr'
  1. Solr
  2. SOLR-847

Enhance the snappull command in ReplicationHandler to take in masterUrl

    Details

    • Type: Improvement
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 1.4
    • Component/s: replication (java)
    • Labels:
      None

      Description

      It should be possible to pass in the masterUrl as a parameter to snappull command so that we can replicate data from arbitrary master

      1. SOLR-847.patch
        12 kB
        Shalin Shekhar Mangar
      2. SOLR-847.patch
        9 kB
        Noble Paul
      3. SOLR-847.patch
        9 kB
        Preetam Rao
      4. SOLR-847.patch
        4 kB
        Noble Paul
      5. SOLR-847.patch
        5 kB
        Noble Paul

        Issue Links

          Activity

          Hide
          noble.paul Noble Paul added a comment -

          take in an extra parameter while triggerring snappull

          Show
          noble.paul Noble Paul added a comment - take in an extra parameter while triggerring snappull
          Hide
          noble.paul Noble Paul added a comment -

          updated w/ trunk

          Show
          noble.paul Noble Paul added a comment - updated w/ trunk
          Hide
          preetam Preetam Rao added a comment -
          • Added Two test cases in TestReplicationHandler.
            1) test for disable polling
            2) test for adding masterUrl parameter to snap pull command. This test case fails. Needs fixing.
          Show
          preetam Preetam Rao added a comment - Added Two test cases in TestReplicationHandler. 1) test for disable polling 2) test for adding masterUrl parameter to snap pull command. This test case fails. Needs fixing.
          Hide
          noble.paul Noble Paul added a comment -

          the testcase works now

          Show
          noble.paul Noble Paul added a comment - the testcase works now
          Hide
          shalinmangar Shalin Shekhar Mangar added a comment -

          Shouldn't we have a way to disable arbitary replication, maybe as a default?

          Show
          shalinmangar Shalin Shekhar Mangar added a comment - Shouldn't we have a way to disable arbitary replication, maybe as a default?
          Hide
          noble.paul Noble Paul added a comment -

          It would be better to think of security outside of the handler.

          Show
          noble.paul Noble Paul added a comment - It would be better to think of security outside of the handler.
          Hide
          shalinmangar Shalin Shekhar Mangar added a comment -

          Perhaps we can configure Solr to disable requests to any URL in a given list of URLs? Or did you mean outside Solr itself?

          Show
          shalinmangar Shalin Shekhar Mangar added a comment - Perhaps we can configure Solr to disable requests to any URL in a given list of URLs? Or did you mean outside Solr itself?
          Hide
          noble.paul Noble Paul added a comment - - edited

          Access control is a common requirement . We must think of moving that to the RequestHandlerBase and provide a common syntax for allow/disallow requests .

          Show
          noble.paul Noble Paul added a comment - - edited Access control is a common requirement . We must think of moving that to the RequestHandlerBase and provide a common syntax for allow/disallow requests .
          Hide
          shalinmangar Shalin Shekhar Mangar added a comment -

          Adding a solrconfig.xml with an empty replication handler section for the test.

          I plan to commit shortly.

          Show
          shalinmangar Shalin Shekhar Mangar added a comment - Adding a solrconfig.xml with an empty replication handler section for the test. I plan to commit shortly.
          Hide
          shalinmangar Shalin Shekhar Mangar added a comment -

          Committed revision 729263.

          Thanks Noble and Preetam!

          Show
          shalinmangar Shalin Shekhar Mangar added a comment - Committed revision 729263. Thanks Noble and Preetam!
          Hide
          shalinmangar Shalin Shekhar Mangar added a comment -

          I just committed another change. Remove 'pollInterval' if it exists in the request parameters because this command is intended to do a snappull only once from the specified masterUrl. Otherwise an executor service is started which does snallpull according to given period.

          Committed revision 729282.

          Show
          shalinmangar Shalin Shekhar Mangar added a comment - I just committed another change. Remove 'pollInterval' if it exists in the request parameters because this command is intended to do a snappull only once from the specified masterUrl. Otherwise an executor service is started which does snallpull according to given period. Committed revision 729282.
          Hide
          gsingers Grant Ingersoll added a comment -

          Bulk close for Solr 1.4

          Show
          gsingers Grant Ingersoll added a comment - Bulk close for Solr 1.4

            People

            • Assignee:
              shalinmangar Shalin Shekhar Mangar
              Reporter:
              noble.paul Noble Paul
            • Votes:
              0 Vote for this issue
              Watchers:
              0 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development