Uploaded image for project: 'Solr'
  1. Solr
  2. SOLR-8455

Improve RecoveryStrategy logging and fix interval-between-recovery-attempts

    XMLWordPrintableJSON

Details

    • Improvement
    • Status: Closed
    • Minor
    • Resolution: Fixed
    • None
    • 5.5, 6.0
    • SolrCloud
    • None

    Description

      This issue addresses multiple minor improvements to RecoveryStrategy:

      • Logging improvements: proper use of Logger interface, improve log messages.
      • Consolidated a debug block into a method and reuse.
      • Get rid of unused and deprecated code.

      In addition, the code over-slept between recovery attempts. The inline comment suggested that the intention was to sleep between 1 second to 1 minute, while implement an exponential sleep interval strategy. However in practice the code sleeps in intervals of 5 seconds and up to 5 minutes. So I fixed the code to sleep at interval of 5 seconds (checking if it was closed in between sleep attempts) and up to 1 minute.

      Attachments

        1. SOLR-8455.patch
          21 kB
          Shai Erera
        2. SOLR-8455.patch
          21 kB
          Shai Erera

        Activity

          People

            shaie Shai Erera
            shaie Shai Erera
            Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved: