Solr
  1. Solr
  2. SOLR-8455

Improve RecoveryStrategy logging and fix interval-between-recovery-attempts

    Details

    • Type: Improvement Improvement
    • Status: Closed
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 5.5, 6.0
    • Component/s: SolrCloud
    • Labels:
      None
    • Flags:
      Patch

      Description

      This issue addresses multiple minor improvements to RecoveryStrategy:

      • Logging improvements: proper use of Logger interface, improve log messages.
      • Consolidated a debug block into a method and reuse.
      • Get rid of unused and deprecated code.

      In addition, the code over-slept between recovery attempts. The inline comment suggested that the intention was to sleep between 1 second to 1 minute, while implement an exponential sleep interval strategy. However in practice the code sleeps in intervals of 5 seconds and up to 5 minutes. So I fixed the code to sleep at interval of 5 seconds (checking if it was closed in between sleep attempts) and up to 1 minute.

      1. SOLR-8455.patch
        21 kB
        Shai Erera
      2. SOLR-8455.patch
        21 kB
        Shai Erera

        Activity

        Hide
        Shai Erera added a comment -

        Patch addresses the above.

        Show
        Shai Erera added a comment - Patch addresses the above.
        Hide
        Shai Erera added a comment -

        Patch updated with a CHANGES record. If there are no objections, I will commit it soon.

        Show
        Shai Erera added a comment - Patch updated with a CHANGES record. If there are no objections, I will commit it soon.
        Hide
        ASF subversion and git services added a comment -

        Commit 1721531 from Shai Erera in branch 'dev/trunk'
        [ https://svn.apache.org/r1721531 ]

        SOLR-8455: Improve RecoveryStrategy logging and fix interval-between-recovery-attempts

        Show
        ASF subversion and git services added a comment - Commit 1721531 from Shai Erera in branch 'dev/trunk' [ https://svn.apache.org/r1721531 ] SOLR-8455 : Improve RecoveryStrategy logging and fix interval-between-recovery-attempts
        Hide
        ASF subversion and git services added a comment -

        Commit 1721533 from Shai Erera in branch 'dev/branches/branch_5x'
        [ https://svn.apache.org/r1721533 ]

        SOLR-8455: Improve RecoveryStrategy logging and fix interval-between-recovery-attempts

        Show
        ASF subversion and git services added a comment - Commit 1721533 from Shai Erera in branch 'dev/branches/branch_5x' [ https://svn.apache.org/r1721533 ] SOLR-8455 : Improve RecoveryStrategy logging and fix interval-between-recovery-attempts
        Hide
        Shai Erera added a comment -

        Committed to trunk and 5x.

        Show
        Shai Erera added a comment - Committed to trunk and 5x.

          People

          • Assignee:
            Shai Erera
            Reporter:
            Shai Erera
          • Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development