Uploaded image for project: 'Solr'
  1. Solr
  2. SOLR-8454

Improve logging by ZkStateReader and clean up dead code

    Details

    • Type: Improvement
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 5.5, 6.0
    • Component/s: SolrCloud
    • Labels:
      None

      Description

      Improve logging output by ZkStateReader, by adding the following:

      • Use LOG.foo() with parameters properly (i.e. not concatenating strings w/ +)
      • Surround parameters with [], to help readability, especially w/ empty values
      • Add missing string messages, where I felt a message will clarify
      • Convert some try-catch to a try-multicatch and improve output log message

      Also, clean up dead code.

        Attachments

        1. SOLR-8454.patch
          22 kB
          Shai Erera
        2. SOLR-8454.patch
          24 kB
          Shai Erera
        3. SOLR-8454.patch
          24 kB
          Shai Erera
        4. SOLR-8454.patch
          27 kB
          Anshum Gupta

          Activity

            People

            • Assignee:
              shaie Shai Erera
              Reporter:
              shaie Shai Erera
            • Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: