Uploaded image for project: 'Solr'
  1. Solr
  2. SOLR-8453

Jetty update from 9.2 to 9.3 causes the server to reset formerly legitimate client connections.

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 5.5, 6.0
    • Component/s: None
    • Labels:
      None

      Description

      The basic problem is that when we are streaming in updates via a client, an update can fail in a way that further updates in the request will not be processed, but not in a way that causes the client to stop and finish up the request before the server does something else with that connection.

      This seems to mean that even after the server stops processing the request, the concurrent update client is still in the process of sending the request. It seems previously, Jetty would not go after the connection very quickly after the server processing thread was stopped via exception, and the client (usually?) had time to clean up properly. But after the Jetty upgrade from 9.2 to 9.3, Jetty closes the connection on the server sooner than previous versions , and the client does not end up getting notified of the original exception at all and instead hits a connection reset exception. The result was random fails due to connection reset throughout our tests and one particular test failing consistently. Even before this update, it does not seem like we are acting in a safe or 'behaved' manner, but our version of Jetty was relaxed enough (or a bug was fixed?) for our tests to work out.

        Attachments

        1. SOLR-8453.patch
          19 kB
          Mark Miller
        2. SOLR-8453.patch
          7 kB
          Mark Miller
        3. SOLR-8453.patch
          27 kB
          Mark Miller
        4. SOLR-8453.patch
          31 kB
          Mark Miller
        5. SOLR-8453.patch
          31 kB
          Mark Miller
        6. SOLR-8453.patch
          34 kB
          Mark Miller
        7. SOLR-8453.patch
          38 kB
          Mark Miller
        8. SOLR-8453.patch
          2 kB
          Mark Miller
        9. SOLR-8453.patch
          3 kB
          Mark Miller
        10. SOLR-8453_test.patch
          6 kB
          Yonik Seeley
        11. SOLR-8453_test.patch
          6 kB
          Yonik Seeley
        12. jetty9.3.pcapng
          554 kB
          Mark Miller
        13. jetty9.2.pcapng
          547 kB
          Mark Miller

          Issue Links

            Activity

              People

              • Assignee:
                markrmiller@gmail.com Mark Miller
                Reporter:
                markrmiller@gmail.com Mark Miller
              • Votes:
                0 Vote for this issue
                Watchers:
                7 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved: