Solr
  1. Solr
  2. SOLR-8452

replace "partialResults" occurrences with SolrQueryResponse.RESPONSE_HEADER_PARTIAL_RESULTS_KEY

    Details

    • Type: Task Task
    • Status: Closed
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 5.5, 6.0
    • Component/s: None
    • Labels:
      None

      Description

      proposed patch against trunk to follow (The TestSolrQueryResponse.testResponseHeaderPartialResults() test within the patch is to ensure that inadvertent, non-backwards-compatible changes to SolrQueryResponse.RESPONSE_HEADER_PARTIAL_RESULTS_KEY result in test failure.)

      1. SOLR-8452.patch
        20 kB
        Christine Poerschke

        Issue Links

          Activity

          Hide
          ASF subversion and git services added a comment -

          Commit 1721450 from Christine Poerschke in branch 'dev/trunk'
          [ https://svn.apache.org/r1721450 ]

          SOLR-8452: replace "partialResults" occurrences with SolrQueryResponse.RESPONSE_HEADER_PARTIAL_RESULTS_KEY

          Show
          ASF subversion and git services added a comment - Commit 1721450 from Christine Poerschke in branch 'dev/trunk' [ https://svn.apache.org/r1721450 ] SOLR-8452 : replace "partialResults" occurrences with SolrQueryResponse.RESPONSE_HEADER_PARTIAL_RESULTS_KEY
          Hide
          Yonik Seeley added a comment -

          It's not a big deal, but I'm not sure we should be replacing literals with references in tests, as it actually reduces what is actually tested. If someone accidentally (or on purpose) change the constant, all of the tests will magically pass.

          Show
          Yonik Seeley added a comment - It's not a big deal, but I'm not sure we should be replacing literals with references in tests, as it actually reduces what is actually tested. If someone accidentally (or on purpose) change the constant, all of the tests will magically pass.
          Hide
          Christine Poerschke added a comment -

          The (added by this revision) TestSolrQueryResponse.testResponseHeaderPartialResults() test would also have to accidentally (or on purpose) be changed to match the changed constant value, but yes, that would be only one specific failed test instead of potentially several general failing tests.

          Show
          Christine Poerschke added a comment - The (added by this revision) TestSolrQueryResponse.testResponseHeaderPartialResults() test would also have to accidentally (or on purpose) be changed to match the changed constant value, but yes, that would be only one specific failed test instead of potentially several general failing tests.
          Hide
          Yonik Seeley added a comment -

          Ah, ok, I hadn't realized you added a specific test.

          I've seen people write tests in both styles in the past (just carrying over what is good style in the code to the tests), but I never got around to mentioning the downsides of doing that.

          Show
          Yonik Seeley added a comment - Ah, ok, I hadn't realized you added a specific test. I've seen people write tests in both styles in the past (just carrying over what is good style in the code to the tests), but I never got around to mentioning the downsides of doing that.
          Hide
          ASF subversion and git services added a comment -

          Commit 1721465 from Christine Poerschke in branch 'dev/branches/branch_5x'
          [ https://svn.apache.org/r1721465 ]

          SOLR-8452: replace "partialResults" occurrences with SolrQueryResponse.RESPONSE_HEADER_PARTIAL_RESULTS_KEY (merge in revision 1721450 from trunk)

          Show
          ASF subversion and git services added a comment - Commit 1721465 from Christine Poerschke in branch 'dev/branches/branch_5x' [ https://svn.apache.org/r1721465 ] SOLR-8452 : replace "partialResults" occurrences with SolrQueryResponse.RESPONSE_HEADER_PARTIAL_RESULTS_KEY (merge in revision 1721450 from trunk)

            People

            • Assignee:
              Christine Poerschke
              Reporter:
              Christine Poerschke
            • Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development