Uploaded image for project: 'Solr'
  1. Solr
  2. SOLR-8443

Change /stream handler http param from "stream" to "expr"

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: None
    • Component/s: SolrJ
    • Labels:
      None

      Description

      When passing in a Streaming Expression to the /stream handler you currently use the "stream" http parameter. This dates back to when serialized TupleStream objects were passed in. Now that the /stream handler only accepts Streaming Expressions it makes sense to rename this parameter to "expr".

      For example:

      http://localhost:8983/collection1/stream?expr=search(...)

      1. SOLR-8443.patch
        1 kB
        Joel Bernstein

        Issue Links

          Activity

          Hide
          dpgove Dennis Gove added a comment - - edited

          If open to other suggestions, I find that I tend to refer to that parameter as the expression. Maybe expr=search(....).

          My thinking here is that one is providing a (potentially complex) expression made up of function calls.

          Show
          dpgove Dennis Gove added a comment - - edited If open to other suggestions, I find that I tend to refer to that parameter as the expression. Maybe expr=search(....). My thinking here is that one is providing a (potentially complex) expression made up of function calls.
          Hide
          joel.bernstein Joel Bernstein added a comment -

          I like it. I'll update the ticket.

          Show
          joel.bernstein Joel Bernstein added a comment - I like it. I'll update the ticket.
          Hide
          joel.bernstein Joel Bernstein added a comment -

          Patch with all streaming tests passing

          Show
          joel.bernstein Joel Bernstein added a comment - Patch with all streaming tests passing
          Hide
          jira-bot ASF subversion and git services added a comment -

          Commit 1720849 from Joel Bernstein in branch 'dev/trunk'
          [ https://svn.apache.org/r1720849 ]

          SOLR-8443: Change /stream handler http param from stream to expr

          Show
          jira-bot ASF subversion and git services added a comment - Commit 1720849 from Joel Bernstein in branch 'dev/trunk' [ https://svn.apache.org/r1720849 ] SOLR-8443 : Change /stream handler http param from stream to expr

            People

            • Assignee:
              Unassigned
              Reporter:
              joel.bernstein Joel Bernstein
            • Votes:
              0 Vote for this issue
              Watchers:
              4 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development