Solr
  1. Solr
  2. SOLR-8419

TermVectorComponent distributed-search issues

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 5.5
    • Labels:
      None

      Description

      TermVectorComponent supports distributed-search since SOLR-3229 added it. Unlike most other components, this one tries to support schemas without a UniqueKey. However it's logic for attempting to do this was made faulty with the introduction of distrib.singlePass, and furthermore this part wasn't tested any way. In this issue I want to remove support for schemas lacking a UniqueKey with this component (only for distributed-search).

      1. SOLR_8419.patch
        9 kB
        David Smiley
      2. SOLR_8419.patch
        6 kB
        David Smiley

        Issue Links

          Activity

          Hide
          David Smiley added a comment -

          The attach patch:

          • Fixes the invalid/confusing response when there's a distributed single-pass situation.
          • Removed uniqueKeyFieldName as a key in the TV response NamedList. Okay I didn't have to do this but this seemed totally out of place. HighlightComponent & DebugComponent don't do this.
          • Added test that fails without these changes – the distrib.singlePass case.

          The changes also then allows for an eventual refactoring of common code in finishStage (the loop filling arr). This is the part affected by a distrib.singlePass bug in 3 search components. I won't do that refactoring here though; I'll do it in BNGS-8059.

          Assuming tests pass I'll commit this in a couple days.

          Show
          David Smiley added a comment - The attach patch: Fixes the invalid/confusing response when there's a distributed single-pass situation. Removed uniqueKeyFieldName as a key in the TV response NamedList. Okay I didn't have to do this but this seemed totally out of place. HighlightComponent & DebugComponent don't do this. Added test that fails without these changes – the distrib.singlePass case. The changes also then allows for an eventual refactoring of common code in finishStage (the loop filling arr ). This is the part affected by a distrib.singlePass bug in 3 search components. I won't do that refactoring here though; I'll do it in BNGS-8059. Assuming tests pass I'll commit this in a couple days.
          Hide
          David Smiley added a comment -

          Slightly updated to adjust tests that were asserting it finds 'uniqueKeyField' in the response, to not expect it anymore (it's going away). When I update CHANGES.txt I'll put 2 entries; one in in the Bug Fixes category and another in Other Changes category to call attention to uniqueKeyField getting removed.

          Show
          David Smiley added a comment - Slightly updated to adjust tests that were asserting it finds 'uniqueKeyField' in the response, to not expect it anymore (it's going away). When I update CHANGES.txt I'll put 2 entries; one in in the Bug Fixes category and another in Other Changes category to call attention to uniqueKeyField getting removed.
          Hide
          ASF subversion and git services added a comment -

          Commit 1720714 from David Smiley in branch 'dev/trunk'
          [ https://svn.apache.org/r1720714 ]

          SOLR-8419: TermVectorComponent: fix accidental inclusion of docs when distrib.singlePass. Remove 'uniqueKeyField' from response. distrib now requires a schema unique key.

          Show
          ASF subversion and git services added a comment - Commit 1720714 from David Smiley in branch 'dev/trunk' [ https://svn.apache.org/r1720714 ] SOLR-8419 : TermVectorComponent: fix accidental inclusion of docs when distrib.singlePass. Remove 'uniqueKeyField' from response. distrib now requires a schema unique key.
          Hide
          ASF subversion and git services added a comment -

          Commit 1720715 from David Smiley in branch 'dev/branches/branch_5x'
          [ https://svn.apache.org/r1720715 ]

          SOLR-8419: TermVectorComponent: fix accidental inclusion of docs when distrib.singlePass. Remove 'uniqueKeyField' from response. distrib now requires a schema unique key.

          Show
          ASF subversion and git services added a comment - Commit 1720715 from David Smiley in branch 'dev/branches/branch_5x' [ https://svn.apache.org/r1720715 ] SOLR-8419 : TermVectorComponent: fix accidental inclusion of docs when distrib.singlePass. Remove 'uniqueKeyField' from response. distrib now requires a schema unique key.

            People

            • Assignee:
              David Smiley
              Reporter:
              David Smiley
            • Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development