Solr
  1. Solr
  2. SOLR-8404

tweak SolrQueryResponse.getToLogAsString(String logid)

    Details

    • Type: Task Task
    • Status: Closed
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 5.5, 6.0
    • Component/s: None
    • Labels:
      None

      Description

      Whilst extending TestSolrQueryResponse in SOLR-8388 I noticed that getToLogAsString(String logid) returns "logidname1=value1 name2=value2 ... " instead of the "logid name1=value1 name2=value2 ..." indicated by its comment.

      summary of changes in patch against trunk:

      • Added space separator between logid and toLog values.
      • Removed trailing space at the end.
      • Added TestSolrQueryResponse.testToLog test case.
      • Reviewed callers of the method and adjusted call arg for two of them.
      1. SOLR-8404.patch
        5 kB
        Christine Poerschke

        Issue Links

          Activity

          Hide
          ASF subversion and git services added a comment -

          Commit 1719503 from Christine Poerschke in branch 'dev/trunk'
          [ https://svn.apache.org/r1719503 ]

          SOLR-8404: tweak SolrQueryResponse.getToLogAsString, add TestSolrQueryResponse.testToLog (Christine Poerschke)

          Show
          ASF subversion and git services added a comment - Commit 1719503 from Christine Poerschke in branch 'dev/trunk' [ https://svn.apache.org/r1719503 ] SOLR-8404 : tweak SolrQueryResponse.getToLogAsString, add TestSolrQueryResponse.testToLog (Christine Poerschke)
          Hide
          ASF subversion and git services added a comment -

          Commit 1719515 from Christine Poerschke in branch 'dev/branches/branch_5x'
          [ https://svn.apache.org/r1719515 ]

          SOLR-8404: tweak SolrQueryResponse.getToLogAsString, add TestSolrQueryResponse.testToLog (merge in revision 1719503 from trunk)

          Show
          ASF subversion and git services added a comment - Commit 1719515 from Christine Poerschke in branch 'dev/branches/branch_5x' [ https://svn.apache.org/r1719515 ] SOLR-8404 : tweak SolrQueryResponse.getToLogAsString, add TestSolrQueryResponse.testToLog (merge in revision 1719503 from trunk)

            People

            • Assignee:
              Christine Poerschke
              Reporter:
              Christine Poerschke
            • Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development