Solr
  1. Solr
  2. SOLR-8387

Solr example configs should ship with managed-schema instead of schema.xml

    Details

    • Type: Improvement Improvement
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 6.0
    • Fix Version/s: 5.5, 6.0
    • Component/s: None
    • Labels:
      None

      Description

      This is a followup of SOLR-8131 . In SOLR-8131 if a schema factory is not specified explicitly managed schema will be used.

      Now since managed schema factory is the default, when a user goes to start solr 6.0 their schema.xml file will get converted to managed-schema . This might seem trappy or confusing to a user. Hence why don't we directly ship with a a file called managed-schema instead of schema.xml . Just a rename of the files in all the example configs that we ship. The data_driven config does that already

      1. SOLR-8387.patch
        3 kB
        Varun Thacker
      2. SOLR-8387.patch
        4 kB
        Varun Thacker

        Activity

        Hide
        Varun Thacker added a comment -

        Small patch. Does a rename of schema.xml -> managed-schema . Currently only example/files and data_driven config sets had this.

        Should this be applied to 5.x as well, since all the configs there explicitly use ManagedSchemaFactory and the rename will happen after they have started solr for the first time?

        Show
        Varun Thacker added a comment - Small patch. Does a rename of schema.xml -> managed-schema . Currently only example/files and data_driven config sets had this. Should this be applied to 5.x as well, since all the configs there explicitly use ManagedSchemaFactory and the rename will happen after they have started solr for the first time?
        Hide
        Erik Hatcher added a comment -

        +1, thanks Varun Thacker

        Show
        Erik Hatcher added a comment - +1, thanks Varun Thacker
        Hide
        Varun Thacker added a comment -

        Thanks Erik for your feedback.

        Should this be applied to 5.x as well, since all the configs there explicitly use ManagedSchemaFactory and the rename will happen after they have started solr for the first time?

        I think we should since example/files and data_driven configset do it in 5.x too and if we don't do it, it will happen on startup anyways . So better not to surprise the users.

        Show
        Varun Thacker added a comment - Thanks Erik for your feedback. Should this be applied to 5.x as well, since all the configs there explicitly use ManagedSchemaFactory and the rename will happen after they have started solr for the first time? I think we should since example/files and data_driven configset do it in 5.x too and if we don't do it, it will happen on startup anyways . So better not to surprise the users.
        Hide
        Varun Thacker added a comment -

        Patch which will apply against trunk and 5.x . From what I am thinking this Jira doesn't require an entry in the "Upgrading from Solr 5.4" section since nothing changes for users in 5.x in terms of default behaviour .

        The default behaviour changes in 6.0 which has already been documented in the "Upgrading from Solr 5.x" section as part of SOLR-8131

        Show
        Varun Thacker added a comment - Patch which will apply against trunk and 5.x . From what I am thinking this Jira doesn't require an entry in the "Upgrading from Solr 5.4" section since nothing changes for users in 5.x in terms of default behaviour . The default behaviour changes in 6.0 which has already been documented in the "Upgrading from Solr 5.x" section as part of SOLR-8131
        Hide
        ASF subversion and git services added a comment -

        Commit 1718932 from Varun Thacker in branch 'dev/trunk'
        [ https://svn.apache.org/r1718932 ]

        SOLR-8387: Rename all schema.xml files to managed-schema

        Show
        ASF subversion and git services added a comment - Commit 1718932 from Varun Thacker in branch 'dev/trunk' [ https://svn.apache.org/r1718932 ] SOLR-8387 : Rename all schema.xml files to managed-schema
        Hide
        ASF subversion and git services added a comment -

        Commit 1718939 from Varun Thacker in branch 'dev/branches/branch_5x'
        [ https://svn.apache.org/r1718939 ]

        SOLR-8387: Rename all schema.xml files to managed-schema

        Show
        ASF subversion and git services added a comment - Commit 1718939 from Varun Thacker in branch 'dev/branches/branch_5x' [ https://svn.apache.org/r1718939 ] SOLR-8387 : Rename all schema.xml files to managed-schema
        Hide
        Varun Thacker added a comment -

        Next up SOLR-6019

        Show
        Varun Thacker added a comment - Next up SOLR-6019

          People

          • Assignee:
            Varun Thacker
            Reporter:
            Varun Thacker
          • Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development