Uploaded image for project: 'Solr'
  1. Solr
  2. SOLR-8375

ReplicaAssigner rejects valid positions

    Details

    • Type: Bug
    • Status: Resolved
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 5.3
    • Fix Version/s: 5.5.1, 6.0
    • Component/s: SolrCloud
    • Labels:
      None
    • Flags:
      Patch

      Description

      ReplicaAssigner rejects any position for which a rule does not return NODE_CAN_BE_ASSIGNED.

      However, if the rule's shard does not apply to the position's shard, Rule returns NOT_APPLICABLE. This is not taken into account, and thus valid rules are being rejected at the moment.

      1. SOLR-8375.patch
        2 kB
        Noble Paul
      2. patch.txt
        1.0 kB
        Kelvin Tan

        Activity

        Hide
        kelvin.tan Kelvin Tan added a comment -

        Patch attached against trunk.

        Show
        kelvin.tan Kelvin Tan added a comment - Patch attached against trunk.
        Hide
        noble.paul Noble Paul added a comment -

        Kelvin Tan This fix looks fine . could you give me a rule+ state combination for a testcase?

        Show
        noble.paul Noble Paul added a comment - Kelvin Tan This fix looks fine . could you give me a rule+ state combination for a testcase?
        Hide
        jira-bot ASF subversion and git services added a comment -

        Commit e44eebf39d62cb68e123c68ac94cecc700ae1087 in lucene-solr's branch refs/heads/master from Noble Paul
        [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=e44eebf ]

        SOLR-8375: ReplicaAssigner rejects valid nodes

        Show
        jira-bot ASF subversion and git services added a comment - Commit e44eebf39d62cb68e123c68ac94cecc700ae1087 in lucene-solr's branch refs/heads/master from Noble Paul [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=e44eebf ] SOLR-8375 : ReplicaAssigner rejects valid nodes
        Hide
        jira-bot ASF subversion and git services added a comment -

        Commit e44eebf39d62cb68e123c68ac94cecc700ae1087 in lucene-solr's branch refs/heads/jira/SOLR-445 from Noble Paul
        [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=e44eebf ]

        SOLR-8375: ReplicaAssigner rejects valid nodes

        Show
        jira-bot ASF subversion and git services added a comment - Commit e44eebf39d62cb68e123c68ac94cecc700ae1087 in lucene-solr's branch refs/heads/jira/ SOLR-445 from Noble Paul [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=e44eebf ] SOLR-8375 : ReplicaAssigner rejects valid nodes
        Hide
        anshumg Anshum Gupta added a comment -

        Noble Paul there's no fix version on this JIRA though there's a change log entry for 6.0. I'm back porting this for 5.5.1 so just wanted to be sure that it was missed accidentally and it's not something that's still open.
        Can you confirm?

        Show
        anshumg Anshum Gupta added a comment - Noble Paul there's no fix version on this JIRA though there's a change log entry for 6.0. I'm back porting this for 5.5.1 so just wanted to be sure that it was missed accidentally and it's not something that's still open. Can you confirm?
        Hide
        jira-bot ASF subversion and git services added a comment -

        Commit 3c6ef10e9e3455fc5027a2f45b889dd1c025d055 in lucene-solr's branch refs/heads/branch_5x from Noble Paul
        [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=3c6ef10 ]

        SOLR-8375: ReplicaAssigner rejects valid nodes

        Show
        jira-bot ASF subversion and git services added a comment - Commit 3c6ef10e9e3455fc5027a2f45b889dd1c025d055 in lucene-solr's branch refs/heads/branch_5x from Noble Paul [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=3c6ef10 ] SOLR-8375 : ReplicaAssigner rejects valid nodes
        Hide
        jira-bot ASF subversion and git services added a comment -

        Commit 38156552730eb5865297f28f5660f5427c43d56a in lucene-solr's branch refs/heads/branch_5_5 from Noble Paul
        [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=3815655 ]

        SOLR-8375: ReplicaAssigner rejects valid nodes

        Show
        jira-bot ASF subversion and git services added a comment - Commit 38156552730eb5865297f28f5660f5427c43d56a in lucene-solr's branch refs/heads/branch_5_5 from Noble Paul [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=3815655 ] SOLR-8375 : ReplicaAssigner rejects valid nodes
        Hide
        noble.paul Noble Paul added a comment -

        It's fixed

        Show
        noble.paul Noble Paul added a comment - It's fixed

          People

          • Assignee:
            noble.paul Noble Paul
            Reporter:
            kelvin.tan Kelvin Tan
          • Votes:
            0 Vote for this issue
            Watchers:
            4 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development