Uploaded image for project: 'Solr'
  1. Solr
  2. SOLR-8363

luceneMatchVerision in solrconfigs under the example directory don't get updated

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Blocker
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 5.4, 6.0
    • Component/s: None
    • Labels:
      None

      Description

      The solrconfig.xml files under the example/ directory don't get updated on a new release.

      example/files/conf/solrconfig still shows 5.0 -https://svn.apache.org/repos/asf/lucene/dev/branches/lucene_solr_5_4/solr/example/files/conf/solrconfig.xml

      Similarly all configs under example/example-DIH/solr/ show 5.2

      1. SOLR-8363.patch
        3 kB
        Varun Thacker
      2. SOLR-8363.patch
        3 kB
        Varun Thacker

        Activity

        Hide
        varunthacker Varun Thacker added a comment -

        Thanks Ryan!

        Show
        varunthacker Varun Thacker added a comment - Thanks Ryan!
        Hide
        jira-bot ASF subversion and git services added a comment -

        Commit 1717905 from Varun Thacker in branch 'dev/branches/lucene_solr_5_4'
        [ https://svn.apache.org/r1717905 ]

        SOLR-8363: Fix luceneMatchVersion check and update in build scripts

        Show
        jira-bot ASF subversion and git services added a comment - Commit 1717905 from Varun Thacker in branch 'dev/branches/lucene_solr_5_4' [ https://svn.apache.org/r1717905 ] SOLR-8363 : Fix luceneMatchVersion check and update in build scripts
        Hide
        jira-bot ASF subversion and git services added a comment -

        Commit 1717904 from Varun Thacker in branch 'dev/branches/branch_5x'
        [ https://svn.apache.org/r1717904 ]

        SOLR-8363: Fix luceneMatchVersion check and update in build scripts

        Show
        jira-bot ASF subversion and git services added a comment - Commit 1717904 from Varun Thacker in branch 'dev/branches/branch_5x' [ https://svn.apache.org/r1717904 ] SOLR-8363 : Fix luceneMatchVersion check and update in build scripts
        Hide
        jira-bot ASF subversion and git services added a comment -

        Commit 1717898 from Varun Thacker in branch 'dev/trunk'
        [ https://svn.apache.org/r1717898 ]

        SOLR-8363: Fix luceneMatchVersion check and update in build scripts

        Show
        jira-bot ASF subversion and git services added a comment - Commit 1717898 from Varun Thacker in branch 'dev/trunk' [ https://svn.apache.org/r1717898 ] SOLR-8363 : Fix luceneMatchVersion check and update in build scripts
        Hide
        upayavira Upayavira added a comment -

        Varun Thacker can you commit this to 5_4, both the fix above, and also the results of running it? I'll then roll an RC when I've confirmed that the solrconfig files in the branch are correct.

        Show
        upayavira Upayavira added a comment - Varun Thacker can you commit this to 5_4, both the fix above, and also the results of running it? I'll then roll an RC when I've confirmed that the solrconfig files in the branch are correct.
        Hide
        varunthacker Varun Thacker added a comment -

        I had the variable names messed up in the previous patch

        Show
        varunthacker Varun Thacker added a comment - I had the variable names messed up in the previous patch
        Hide
        varunthacker Varun Thacker added a comment -

        Upayavira The branch is taking a while to download and have to step out for a 3-4 hours. I can come back, test and commit it.

        Please feel free to commit if you get to it earlier.

        Show
        varunthacker Varun Thacker added a comment - Upayavira The branch is taking a while to download and have to step out for a 3-4 hours. I can come back, test and commit it. Please feel free to commit if you get to it earlier.
        Hide
        varunthacker Varun Thacker added a comment -

        Thanks Ryan Ernst for pointing it out! That made it very simple to understand what changed.

        Upayavira I am currently downloading the 5_4 branch to test out the patch. Could you also quickly try it out to see if it works?

        Show
        varunthacker Varun Thacker added a comment - Thanks Ryan Ernst for pointing it out! That made it very simple to understand what changed. Upayavira I am currently downloading the 5_4 branch to test out the patch. Could you also quickly try it out to see if it works?
        Hide
        rjernst Ryan Ernst added a comment -

        See update_example_solrconfigs in dev-tools/scripts/addVersion.py. The current directory it traverses underneath to find solrconfigs is solr/server/solr/configsets. This was originally using solr/example, but was changed in SOLR-7487.

        Show
        rjernst Ryan Ernst added a comment - See update_example_solrconfigs in dev-tools/scripts/addVersion.py . The current directory it traverses underneath to find solrconfigs is solr/server/solr/configsets . This was originally using solr/example , but was changed in SOLR-7487 .

          People

          • Assignee:
            varunthacker Varun Thacker
            Reporter:
            varunthacker Varun Thacker
          • Votes:
            0 Vote for this issue
            Watchers:
            5 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development