Uploaded image for project: 'Solr'
  1. Solr
  2. SOLR-8360

ExternalFileField.getValueSource uses req.datadir but this.schema

    Details

    • Type: Task
    • Status: Closed
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 5.5, 6.0
    • Component/s: None
    • Labels:
      None

      Description

      ExternalFileField.getValueSource(SchemaField field, QParser parser) has available:

      • datadir
        • parser.getReq().getCore().getDataDir()
        • this.schema.getResourceLoader().getDataDir()
      • schema
        • parser.getReq().getSchema()
        • this.schema

      ExternalFileField.getValueSource uses parser.getReq().getCore().getDataDir() explicitly but implicitly this.schema - should it use parser.getReq().getSchema() instead (Option 1 patch)? Or if in practice actually req.datadir and this.datadir are always the same could we stop using the parser argument (Option 2 patch (1 line))?

        Attachments

        1. SOLR-8360-option2.patch
          0.6 kB
          Christine Poerschke
        2. SOLR-8360-option1.patch
          2 kB
          Christine Poerschke

          Issue Links

            Activity

              People

              • Assignee:
                cpoerschke Christine Poerschke
                Reporter:
                cpoerschke Christine Poerschke
              • Votes:
                0 Vote for this issue
                Watchers:
                3 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved: