[SOLR-8360] ExternalFileField.getValueSource uses req.datadir but this.schema

• Type: Task
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Fix Version/s: 5.5, 6.0
• Assignee: Christine Poerschke
• Reporter: Christine Poerschke
• Created: 02/Dec/15 17:32
• Updated: 09/May/16 18:54
• Resolved: 08/Dec/15 12:55

Description

ExternalFileField.getValueSource(SchemaField field, QParser parser) has available:

• datadir
  • parser.getReq().getCore().getDataDir()
  • this.schema.getResourceLoader().getDataDir()
• schema
  • parser.getReq().getSchema()
  • this.schema

ExternalFileField.getValueSource uses parser.getReq().getCore().getDataDir() explicitly but implicitly this.schema - should it use parser.getReq().getSchema() instead (Option 1 patch)? Or if in practice actually req.datadir and this.datadir are always the same could we stop using the parser argument (Option 2 patch (1 line))?

Issue Links

• is required by: SOLR-8305 replace LatLonType.getValueSource's QParser use