Solr
  1. Solr
  2. SOLR-8338

in OverseerTest replace strings such as "collection1" and "state"

    Details

    • Type: Test Test
    • Status: Closed
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 5.5, 6.0
    • Component/s: None
    • Labels:
      None

      Description

      replace with variable or enum equivalent.

      1. SOLR-8338.patch
        12 kB
        Christine Poerschke

        Issue Links

          Activity

          Hide
          Ishan Chattopadhyaya added a comment -

          +1, LGTM.
          Though, just a thought, should we use SolrTestCaseJ4.DEFAULT_TEST_CORENAME for "collection1"?

          Show
          Ishan Chattopadhyaya added a comment - +1, LGTM. Though, just a thought, should we use SolrTestCaseJ4.DEFAULT_TEST_CORENAME for "collection1"?
          Hide
          Christine Poerschke added a comment -

          Thanks for the review Ishan. I wasn't aware of SolrTestCaseJ4.DEFAULT_TEST_CORENAME until now. How about adding a SolrTestCaseJ4.DEFAULT_TEST_COLLECTION_NAME and then using that instead of the current "collection1"?

          public abstract class SolrTestCaseJ4 extends LuceneTestCase {
           
          -  public static final String DEFAULT_TEST_CORENAME = "collection1";
          +  public static final String DEFAULT_TEST_COLLECTION_NAME = "collection1";
          +  public static final String DEFAULT_TEST_CORENAME = DEFAULT_TEST_COLLECTION_NAME;
          
          Show
          Christine Poerschke added a comment - Thanks for the review Ishan. I wasn't aware of SolrTestCaseJ4.DEFAULT_TEST_CORENAME until now. How about adding a SolrTestCaseJ4.DEFAULT_TEST_COLLECTION_NAME and then using that instead of the current "collection1" ? public abstract class SolrTestCaseJ4 extends LuceneTestCase { - public static final String DEFAULT_TEST_CORENAME = "collection1" ; + public static final String DEFAULT_TEST_COLLECTION_NAME = "collection1" ; + public static final String DEFAULT_TEST_CORENAME = DEFAULT_TEST_COLLECTION_NAME;
          Hide
          Ishan Chattopadhyaya added a comment -

          Sounds good!

          Show
          Ishan Chattopadhyaya added a comment - Sounds good!
          Hide
          ASF subversion and git services added a comment -

          Commit 1717534 from Christine Poerschke in branch 'dev/trunk'
          [ https://svn.apache.org/r1717534 ]

          SOLR-8338: in OverseerTest replace strings such as "collection1" and "state" with variable or enum equivalent

          Show
          ASF subversion and git services added a comment - Commit 1717534 from Christine Poerschke in branch 'dev/trunk' [ https://svn.apache.org/r1717534 ] SOLR-8338 : in OverseerTest replace strings such as "collection1" and "state" with variable or enum equivalent
          Hide
          Christine Poerschke added a comment -

          [ https://svn.apache.org/r1717526 ] was the actual commit but I mistakenly put ${message} as a commit message for it.

          Show
          Christine Poerschke added a comment - [ https://svn.apache.org/r1717526 ] was the actual commit but I mistakenly put ${message} as a commit message for it.
          Hide
          ASF subversion and git services added a comment -

          Commit 1717538 from Christine Poerschke in branch 'dev/branches/branch_5x'
          [ https://svn.apache.org/r1717538 ]

          SOLR-8338: in OverseerTest replace strings such as "collection1" and "state" with variable or enum equivalent (merge in revision 1717526 from trunk)

          Show
          ASF subversion and git services added a comment - Commit 1717538 from Christine Poerschke in branch 'dev/branches/branch_5x' [ https://svn.apache.org/r1717538 ] SOLR-8338 : in OverseerTest replace strings such as "collection1" and "state" with variable or enum equivalent (merge in revision 1717526 from trunk)

            People

            • Assignee:
              Christine Poerschke
              Reporter:
              Christine Poerschke
            • Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development