Uploaded image for project: 'Solr'
  1. Solr
  2. SOLR-8324 Logger Untanglement
  3. SOLR-8330

Restrict logger visibility throughout the codebase to private so that only the file that declares it can use it

    Details

    • Type: Sub-task
    • Status: Closed
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: 6.0
    • Fix Version/s: 5.4, 6.0
    • Component/s: None
    • Labels:

      Description

      As Mike Drob pointed out in Solr-8324, many loggers in Solr are unintentionally shared between classes. Many instances of this are caused by overzealous copy-paste. This can make debugging tougher, as messages appear to come from an incorrect location.

      As discussed in the comments on SOLR-8324, there also might be legitimate reasons for sharing loggers between classes. Where any ambiguity exists, these instances shouldn't be touched.

        Attachments

        1. SOLR-8330-detector.patch
          1 kB
          Uwe Schindler
        2. SOLR-8330-detector.patch
          1 kB
          Uwe Schindler
        3. SOLR-8330-combined.patch
          507 kB
          Jason Gerlowski
        4. SOLR-8330.patch
          393 kB
          Jason Gerlowski
        5. SOLR-8330.patch
          394 kB
          Jason Gerlowski
        6. SOLR-8330.patch
          394 kB
          Jason Gerlowski
        7. SOLR-8330.patch
          423 kB
          Anshum Gupta
        8. SOLR-8330.patch
          485 kB
          Anshum Gupta
        9. SOLR-8330.patch
          514 kB
          Jason Gerlowski
        10. SOLR-8330.patch
          528 kB
          Anshum Gupta

          Issue Links

            Activity

              People

              • Assignee:
                anshumg Anshum Gupta
                Reporter:
                gerlowskija Jason Gerlowski
              • Votes:
                0 Vote for this issue
                Watchers:
                10 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved: