Solr
  1. Solr
  2. SOLR-8315

Remove default core checks in the dispatch filter

    Details

    • Type: Improvement Improvement
    • Status: Closed
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 5.4, 6.0
    • Component/s: None
    • Labels:
      None

      Description

      There are two occurrences in HttpSolrCall that still make checks for a default core.

      // try the default core
      if (core == null) {
          core = cores.getCore("");
      }
      

      Is that needed anymore? I removed them and the tests seems to pass .

      1. SOLR-8315.patch
        1 kB
        Varun Thacker

        Activity

        Hide
        Alan Woodward added a comment -

        There's no default core any more, so that can be nuked.

        Show
        Alan Woodward added a comment - There's no default core any more, so that can be nuked.
        Hide
        Varun Thacker added a comment -

        Simple patch which removes the two checks for default core. I'll commit this soon

        Show
        Varun Thacker added a comment - Simple patch which removes the two checks for default core. I'll commit this soon
        Hide
        ASF subversion and git services added a comment -

        Commit 1715317 from Varun Thacker in branch 'dev/trunk'
        [ https://svn.apache.org/r1715317 ]

        SOLR-8315: Removed default core checks in the dispatch filter since we don't have a default core anymore

        Show
        ASF subversion and git services added a comment - Commit 1715317 from Varun Thacker in branch 'dev/trunk' [ https://svn.apache.org/r1715317 ] SOLR-8315 : Removed default core checks in the dispatch filter since we don't have a default core anymore
        Hide
        ASF subversion and git services added a comment -

        Commit 1715318 from Varun Thacker in branch 'dev/branches/branch_5x'
        [ https://svn.apache.org/r1715318 ]

        SOLR-8315: Removed default core checks in the dispatch filter since we don't have a default core anymore (merged trunk r1715317)

        Show
        ASF subversion and git services added a comment - Commit 1715318 from Varun Thacker in branch 'dev/branches/branch_5x' [ https://svn.apache.org/r1715318 ] SOLR-8315 : Removed default core checks in the dispatch filter since we don't have a default core anymore (merged trunk r1715317)
        Hide
        Varun Thacker added a comment -

        Thanks Alan for confirming!

        Show
        Varun Thacker added a comment - Thanks Alan for confirming!

          People

          • Assignee:
            Varun Thacker
            Reporter:
            Varun Thacker
          • Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development