Details

    • Type: Sub-task Sub-task
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 5.5, 6.0
    • Component/s: Facet Module
    • Labels:
      None

      Description

      The doc set size and number of buckets represents the input data size and intermediate data size for each step of facet. Therefore they are useful metrics to be included in telemetry.

      The output data size is usually defined by user and not too large. Therefore the output data set size is not included.

        Activity

        Hide
        Michael Sun added a comment -

        Here is the patch. It adds two metrics to facet telemetry:
        1. inputDocSetSize: the size of input doc set for each sub-facet.
        2. numBuckets: number of unique buckets. It is the same number to the numBuckets in facet query result if numBuckets param is set to true in query. and is for field facet only. The reason to dup in facet telemetry is

        • query user may not turn on numBuckets but the operation and monitoring team still want to view numBucket information.
        • operation and monitoring team may not be allowed to view query result.
        Show
        Michael Sun added a comment - Here is the patch. It adds two metrics to facet telemetry: 1. inputDocSetSize: the size of input doc set for each sub-facet. 2. numBuckets: number of unique buckets. It is the same number to the numBuckets in facet query result if numBuckets param is set to true in query. and is for field facet only. The reason to dup in facet telemetry is query user may not turn on numBuckets but the operation and monitoring team still want to view numBucket information. operation and monitoring team may not be allowed to view query result.
        Hide
        Yonik Seeley added a comment -

        Thanks Michael, I changed inputDocSetSize to domainSize and committed.

        Show
        Yonik Seeley added a comment - Thanks Michael, I changed inputDocSetSize to domainSize and committed.
        Hide
        Michael Sun added a comment -

        Hi Yonik,

        It looks it's not committed yet. Thanks.

        Michael

        On Mon, Jan 11, 2016 at 8:34 AM, Yonik Seeley (JIRA) <jira@apache.org>

        Show
        Michael Sun added a comment - Hi Yonik, It looks it's not committed yet. Thanks. Michael On Mon, Jan 11, 2016 at 8:34 AM, Yonik Seeley (JIRA) <jira@apache.org>
        Hide
        ASF subversion and git services added a comment -

        Commit 1724341 from Yonik Seeley in branch 'dev/trunk'
        [ https://svn.apache.org/r1724341 ]

        SOLR-8312: add numBuckets and domainSize to facet telemetry

        Show
        ASF subversion and git services added a comment - Commit 1724341 from Yonik Seeley in branch 'dev/trunk' [ https://svn.apache.org/r1724341 ] SOLR-8312 : add numBuckets and domainSize to facet telemetry
        Hide
        ASF subversion and git services added a comment -

        Commit 1724342 from Yonik Seeley in branch 'dev/branches/branch_5x'
        [ https://svn.apache.org/r1724342 ]

        SOLR-8312: add numBuckets and domainSize to facet telemetry

        Show
        ASF subversion and git services added a comment - Commit 1724342 from Yonik Seeley in branch 'dev/branches/branch_5x' [ https://svn.apache.org/r1724342 ] SOLR-8312 : add numBuckets and domainSize to facet telemetry
        Hide
        Yonik Seeley added a comment -

        It looks it's not committed yet

        Weird... looks like I got interrupted at just the wrong time and assumed I had

        Show
        Yonik Seeley added a comment - It looks it's not committed yet Weird... looks like I got interrupted at just the wrong time and assumed I had
        Hide
        Michael Sun added a comment -

        It happens

        On Tue, Jan 12, 2016 at 4:55 PM, Yonik Seeley (JIRA) <jira@apache.org>

        Show
        Michael Sun added a comment - It happens On Tue, Jan 12, 2016 at 4:55 PM, Yonik Seeley (JIRA) <jira@apache.org>

          People

          • Assignee:
            Unassigned
            Reporter:
            Michael Sun
          • Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development