Solr
  1. Solr
  2. SOLR-8305

replace LatLonType.getValueSource's QParser use

    Details

    • Type: Wish Wish
    • Status: Closed
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 5.5, 6.0
    • Component/s: None
    • Labels:
      None

      Description

      Question with patch against trunk. Context is that elsewhere in the classes the IndexSchema member is used instead of the QParser method parameter and would the resulting schema not be the same when using the member instead of the parameter? Motivation here is potential removal of the QParser argument from the getValueSource signature.

      1. SOLR-8305.patch
        0.8 kB
        Christine Poerschke
      2. SOLR-8305.patch
        1 kB
        Christine Poerschke

        Issue Links

          Activity

          Hide
          Christine Poerschke added a comment -

          updated/reduced patch to account for SOLR-8360

          Show
          Christine Poerschke added a comment - updated/reduced patch to account for SOLR-8360
          Hide
          David Smiley added a comment -

          +1 to the patch

          +0 to also eventually removing QParser from getValueSource's signature (separate issue). I've found it useful for doing interesting/custom things from the getValueSource method since it provides context to the outside world beyond simply fetching the valueSource. However I believe the cases where I've used it, I could have used the SolrRequestInfo ThreadLocal/singleton.

          Show
          David Smiley added a comment - +1 to the patch +0 to also eventually removing QParser from getValueSource's signature (separate issue). I've found it useful for doing interesting/custom things from the getValueSource method since it provides context to the outside world beyond simply fetching the valueSource. However I believe the cases where I've used it, I could have used the SolrRequestInfo ThreadLocal/singleton.
          Hide
          ASF subversion and git services added a comment -

          Commit 1719080 from Christine Poerschke in branch 'dev/trunk'
          [ https://svn.apache.org/r1719080 ]

          SOLR-8305: replace LatLonType.getValueSource's QParser use

          Show
          ASF subversion and git services added a comment - Commit 1719080 from Christine Poerschke in branch 'dev/trunk' [ https://svn.apache.org/r1719080 ] SOLR-8305 : replace LatLonType.getValueSource's QParser use
          Hide
          ASF subversion and git services added a comment -

          Commit 1719090 from Christine Poerschke in branch 'dev/branches/branch_5x'
          [ https://svn.apache.org/r1719090 ]

          SOLR-8305: replace LatLonType.getValueSource's QParser use (merge in revision 1719080 from trunk)

          Show
          ASF subversion and git services added a comment - Commit 1719090 from Christine Poerschke in branch 'dev/branches/branch_5x' [ https://svn.apache.org/r1719090 ] SOLR-8305 : replace LatLonType.getValueSource's QParser use (merge in revision 1719080 from trunk)

            People

            • Assignee:
              Christine Poerschke
              Reporter:
              Christine Poerschke
            • Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development