Solr
  1. Solr
  2. SOLR-8303

CustomBufferedIndexInput should include resource description when throwing EOFException

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 4.10.3, 5.3
    • Fix Version/s: 5.4, 6.0
    • Component/s: None
    • Labels:
      None

      Description

      The other implementations of IndexInput all include the resource description when throwing an EOFException, for example:
      https://github.com/apache/lucene-solr/blob/trunk/lucene/core/src/java/org/apache/lucene/store/ByteBufferIndexInput.java#L81

      CustomBufferedIndexInput should follow suit.

        Activity

        Hide
        Mike Drob added a comment -

        Patch attached for trunk.

        Show
        Mike Drob added a comment - Patch attached for trunk.
        Hide
        Uwe Schindler added a comment -

        +1 LGTM

        Show
        Uwe Schindler added a comment - +1 LGTM
        Hide
        Mike Drob added a comment -

        Uwe Schindler - will you be able to commit this (eventually, not trying to rush you), or should I try to get some other folks' attention?

        Show
        Mike Drob added a comment - Uwe Schindler - will you be able to commit this (eventually, not trying to rush you), or should I try to get some other folks' attention?
        Hide
        Uwe Schindler added a comment -

        Hi Mike,
        I can take this issue. Will commit in a moment.

        Show
        Uwe Schindler added a comment - Hi Mike, I can take this issue. Will commit in a moment.
        Hide
        ASF subversion and git services added a comment -

        Commit 1715402 from Uwe Schindler in branch 'dev/trunk'
        [ https://svn.apache.org/r1715402 ]

        SOLR-8303: CustomBufferedIndexInput now includes resource description when throwing EOFException

        Show
        ASF subversion and git services added a comment - Commit 1715402 from Uwe Schindler in branch 'dev/trunk' [ https://svn.apache.org/r1715402 ] SOLR-8303 : CustomBufferedIndexInput now includes resource description when throwing EOFException
        Hide
        ASF subversion and git services added a comment -

        Commit 1715403 from Uwe Schindler in branch 'dev/branches/branch_5x'
        [ https://svn.apache.org/r1715403 ]

        Merged revision(s) 1715402 from lucene/dev/trunk:
        SOLR-8303: CustomBufferedIndexInput now includes resource description when throwing EOFException

        Show
        ASF subversion and git services added a comment - Commit 1715403 from Uwe Schindler in branch 'dev/branches/branch_5x' [ https://svn.apache.org/r1715403 ] Merged revision(s) 1715402 from lucene/dev/trunk: SOLR-8303 : CustomBufferedIndexInput now includes resource description when throwing EOFException
        Hide
        Uwe Schindler added a comment -

        Thanks Mike.

        Show
        Uwe Schindler added a comment - Thanks Mike.

          People

          • Assignee:
            Uwe Schindler
            Reporter:
            Mike Drob
          • Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development