Solr
  1. Solr
  2. SOLR-8300

Use constants for the /overseer_elect znode

    Details

    • Type: Improvement Improvement
    • Status: Closed
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 5.4, 6.0
    • Component/s: None
    • Labels:
      None

      Description

      We should reference the OverseerElectionContext.PATH constant instead of using it's string equivalent form.

      1. SOLR-8300.patch
        9 kB
        Varun Thacker

        Activity

        Hide
        Varun Thacker added a comment -

        Patch which does the following:

        • Rename OverseerElectionContext.PATH to OverseerElectionContext.OVERSEER_ELECT to more accurately name the constant
        • The code now uses the OverseerElectionContext.OVERSEER_ELECT constant instead of using the string directly
        • All test cases use the string instead of the constant
        Show
        Varun Thacker added a comment - Patch which does the following: Rename OverseerElectionContext.PATH to OverseerElectionContext.OVERSEER_ELECT to more accurately name the constant The code now uses the OverseerElectionContext.OVERSEER_ELECT constant instead of using the string directly All test cases use the string instead of the constant
        Hide
        Varun Thacker added a comment -

        All tests pass. I'll commit this soon if there aren't any objections.

        Show
        Varun Thacker added a comment - All tests pass. I'll commit this soon if there aren't any objections.
        Hide
        ASF subversion and git services added a comment -

        Commit 1714841 from Varun Thacker in branch 'dev/trunk'
        [ https://svn.apache.org/r1714841 ]

        SOLR-8300: Use constants for the /overseer_elect znode

        Show
        ASF subversion and git services added a comment - Commit 1714841 from Varun Thacker in branch 'dev/trunk' [ https://svn.apache.org/r1714841 ] SOLR-8300 : Use constants for the /overseer_elect znode
        Hide
        ASF subversion and git services added a comment -

        Commit 1714847 from Varun Thacker in branch 'dev/branches/branch_5x'
        [ https://svn.apache.org/r1714847 ]

        SOLR-8300: Use constants for the /overseer_elect znode(merged trunk r1714841)

        Show
        ASF subversion and git services added a comment - Commit 1714847 from Varun Thacker in branch 'dev/branches/branch_5x' [ https://svn.apache.org/r1714847 ] SOLR-8300 : Use constants for the /overseer_elect znode(merged trunk r1714841)
        Hide
        Varun Thacker added a comment -

        Re-opening it to add Trunk to the Fix Versions list since this had been committed to trunk too

        Show
        Varun Thacker added a comment - Re-opening it to add Trunk to the Fix Versions list since this had been committed to trunk too

          People

          • Assignee:
            Varun Thacker
            Reporter:
            Varun Thacker
          • Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development