Solr
  1. Solr
  2. SOLR-8286

Remove instances of solr.hdfs.blockcache.write.enabled from tests and docs

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 5.0
    • Fix Version/s: 5.4, 6.0
    • Component/s: documentation, Tests
    • Labels:
      None

      Description

      solr.hdfs.blockcache.write.enabled is currently disabled whether or not you set it in the solr configs. It makes sense to just avoid mentioning it in the docs (it's still there on https://cwiki.apache.org/confluence/display/solr/Running+Solr+on+HDFS) and the morphlines examples. Best case, it's unnecessary information. Worse case, it causes people trouble on versions where it's not disabled.

      1. SOLR-8286.patch
        4 kB
        Gregory Chanan

        Activity

        Hide
        Gregory Chanan added a comment -

        Patch that removes references to the write side of the block cache from the test configs. Once this is in, I'll remove it from the docs as well.

        Show
        Gregory Chanan added a comment - Patch that removes references to the write side of the block cache from the test configs. Once this is in, I'll remove it from the docs as well.
        Hide
        Gregory Chanan added a comment -

        Also: I didn't remove:

          public static final String BLOCKCACHE_WRITE_ENABLED = "solr.hdfs.blockcache.write.enabled"; // currently buggy and disabled

        In case someone is depending on that.

        Show
        Gregory Chanan added a comment - Also: I didn't remove: public static final String BLOCKCACHE_WRITE_ENABLED = "solr.hdfs.blockcache.write.enabled" ; // currently buggy and disabled In case someone is depending on that.
        Hide
        ASF subversion and git services added a comment -

        Commit 1714278 from gchanan@apache.org in branch 'dev/trunk'
        [ https://svn.apache.org/r1714278 ]

        SOLR-8286: Remove instances of solr.hdfs.blockcache.write.enabled from tests and docs

        Show
        ASF subversion and git services added a comment - Commit 1714278 from gchanan@apache.org in branch 'dev/trunk' [ https://svn.apache.org/r1714278 ] SOLR-8286 : Remove instances of solr.hdfs.blockcache.write.enabled from tests and docs
        Hide
        ASF subversion and git services added a comment -

        Commit 1714279 from gchanan@apache.org in branch 'dev/branches/branch_5x'
        [ https://svn.apache.org/r1714279 ]

        SOLR-8286: Remove instances of solr.hdfs.blockcache.write.enabled from tests and docs

        Show
        ASF subversion and git services added a comment - Commit 1714279 from gchanan@apache.org in branch 'dev/branches/branch_5x' [ https://svn.apache.org/r1714279 ] SOLR-8286 : Remove instances of solr.hdfs.blockcache.write.enabled from tests and docs
        Hide
        Gregory Chanan added a comment -

        Committed to 5.4, Trunk and removed from the cwiki page.

        Show
        Gregory Chanan added a comment - Committed to 5.4, Trunk and removed from the cwiki page.

          People

          • Assignee:
            Gregory Chanan
            Reporter:
            Gregory Chanan
          • Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development