Uploaded image for project: 'Solr'
  1. Solr
  2. SOLR-8057 Change default Sim to BM25 (w/backcompat config handling)
  3. SOLR-8261

Change the wrapped per-field default in SchemaSimilarityFactory to BM25 (conditional on luceneMatchVersion for backcompat)

    Details

    • Type: Sub-task
    • Status: Resolved
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 6.0
    • Component/s: None
    • Labels:
      None

      Description

      As outlined in parent issue...

      • use ClassicSimilarity as per-field default when luceneMatchVersion < 6.0
      • use BM25Similarity as per-field default when luceneMatchVersion >= 6.0

      SOLR-8329 can be used for folks who really want ClassicSimilarity as the per-field default but also really want luceneMatchVersion >= 6.0 for any other reasons

        Issue Links

          Activity

          Hide
          hossman Hoss Man added a comment -

          Quick patch extracted from my older patch in SOLR-8057 ...

          • SchemaSimilarityFactory udpated to use BM25 if luceneMatchVersion >= 6
          • cloned TestPerFieldSimilarity as TestPerFieldSimilarityClassic
            • TestPerFieldSimilarityClassic set's older luceneMatchVersion
            • TestPerFieldSimilarity updated to account for new BM25 defaults

          ...tests & precommit currently pass, but I want to re-review more closely in isolation and think about any other tests that should be added before committing.

          Show
          hossman Hoss Man added a comment - Quick patch extracted from my older patch in SOLR-8057 ... SchemaSimilarityFactory udpated to use BM25 if luceneMatchVersion >= 6 cloned TestPerFieldSimilarity as TestPerFieldSimilarityClassic TestPerFieldSimilarityClassic set's older luceneMatchVersion TestPerFieldSimilarity updated to account for new BM25 defaults ...tests & precommit currently pass, but I want to re-review more closely in isolation and think about any other tests that should be added before committing.
          Hide
          jira-bot ASF subversion and git services added a comment -

          Commit 1713557 from hossman@apache.org in branch 'dev/trunk'
          [ https://svn.apache.org/r1713557 ]

          SOLR-8261: Change SchemaSimilarityFactory default to BM25Similarity

          Show
          jira-bot ASF subversion and git services added a comment - Commit 1713557 from hossman@apache.org in branch 'dev/trunk' [ https://svn.apache.org/r1713557 ] SOLR-8261 : Change SchemaSimilarityFactory default to BM25Similarity
          Hide
          hossman Hoss Man added a comment -

          I couldn't find anything else that seemed necessary to update for this change, other then fixing the test to use a Version.* constant instead of a magic string.

          Show
          hossman Hoss Man added a comment - I couldn't find anything else that seemed necessary to update for this change, other then fixing the test to use a Version.* constant instead of a magic string.
          Hide
          jira-bot ASF subversion and git services added a comment -

          Commit 1715950 from hossman@apache.org in branch 'dev/trunk'
          [ https://svn.apache.org/r1715950 ]

          SOLR-8261 + SOLR-8329 + SOLR-8239: update 6.0 upgrade instructions to note new defaultSimFromFieldType option for people who want backcompat behavior even if luceneMatchVersion is increased. Also fixed some typos

          Show
          jira-bot ASF subversion and git services added a comment - Commit 1715950 from hossman@apache.org in branch 'dev/trunk' [ https://svn.apache.org/r1715950 ] SOLR-8261 + SOLR-8329 + SOLR-8239 : update 6.0 upgrade instructions to note new defaultSimFromFieldType option for people who want backcompat behavior even if luceneMatchVersion is increased. Also fixed some typos
          Hide
          hossman Hoss Man added a comment -

          fixed mistake in description & added note about SOLR-8329

          Show
          hossman Hoss Man added a comment - fixed mistake in description & added note about SOLR-8329

            People

            • Assignee:
              hossman Hoss Man
              Reporter:
              hossman Hoss Man
            • Votes:
              0 Vote for this issue
              Watchers:
              1 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development