Solr
  1. Solr
  2. SOLR-8259

Add getCoreContainer() method to JettySolrRunner

    Details

    • Type: Improvement Improvement
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 5.4
    • Component/s: None
    • Labels:
      None

      Description

      We have this all over our tests:

      CoreContainer cores = ((SolrDispatchFilter) jetty.getDispatchFilter().getFilter()).getCores();
      

      We should add a sugar method explicitly for doing this.

      1. SOLR-8259.patch
        44 kB
        Alan Woodward

        Activity

        Hide
        Alan Woodward added a comment -

        Patch removing JettySolrRunner.getDispatchFilter() and adding .getCoreContainer() and .getSolrDispatchFilter() methods. In 5.x I'll just deprecate .getDispatchFilter().

        Show
        Alan Woodward added a comment - Patch removing JettySolrRunner.getDispatchFilter() and adding .getCoreContainer() and .getSolrDispatchFilter() methods. In 5.x I'll just deprecate .getDispatchFilter().
        Hide
        ASF subversion and git services added a comment -

        Commit 1713601 from Alan Woodward in branch 'dev/trunk'
        [ https://svn.apache.org/r1713601 ]

        SOLR-8259: Add getCoreContainer() method to JettySolrRunner

        Show
        ASF subversion and git services added a comment - Commit 1713601 from Alan Woodward in branch 'dev/trunk' [ https://svn.apache.org/r1713601 ] SOLR-8259 : Add getCoreContainer() method to JettySolrRunner
        Hide
        ASF subversion and git services added a comment -

        Commit 1713602 from Alan Woodward in branch 'dev/trunk'
        [ https://svn.apache.org/r1713602 ]

        SOLR-8259: Remove deprecated getDispatchFilter() method from trunk

        Show
        ASF subversion and git services added a comment - Commit 1713602 from Alan Woodward in branch 'dev/trunk' [ https://svn.apache.org/r1713602 ] SOLR-8259 : Remove deprecated getDispatchFilter() method from trunk
        Hide
        ASF subversion and git services added a comment -

        Commit 1713604 from Alan Woodward in branch 'dev/branches/branch_5x'
        [ https://svn.apache.org/r1713604 ]

        SOLR-8259: Add getCoreContainer() method to JettySolrRunner

        Show
        ASF subversion and git services added a comment - Commit 1713604 from Alan Woodward in branch 'dev/branches/branch_5x' [ https://svn.apache.org/r1713604 ] SOLR-8259 : Add getCoreContainer() method to JettySolrRunner

          People

          • Assignee:
            Alan Woodward
            Reporter:
            Alan Woodward
          • Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development