Uploaded image for project: 'Solr'
  1. Solr
  2. SOLR-8246

create_core command gives confusing messages if broken config is given, fixed, given again

    Details

    • Type: Improvement
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 5.3.1
    • Fix Version/s: 5.4, 6.0
    • Component/s: scripts and tools
    • Labels:

      Description

      If the config used to create a core, the command complains and aborts:

      Example:

      $ bin/solr create_core -c minicore -d ../miniconf/
      
      Creating new core 'minicore' using command:
      http://localhost:8983/solr/admin/cores?action=CREATE&name=minicore&instanceDir=minicore
      
      ERROR: Error CREATEing SolrCore 'minicore': Unable to create core [minicore] Caused by: The element type "dynamicField" must be terminated by the matching end-tag "</dynamicField>".
      

      However, after fixing the problem, trying to re-run the command gives the same error, causing all sorts of confusion.

      What actually happened is that config has been copied to the destination directory and then when the command is run the second time, it does not recopy fresh - and fixed - files, but just reuses the previously copied - broken - ones.

      The workaround is to manually delete created destination directory and rerun the command. But it is far from obvious.

      The fix would be either undoing the copy - a delete. The minimal fix would be a log statement that the directory was copied (which would help example logs too). And perhaps an extra message when the create command failed that files were copied and may need to be manually deleted.

        Attachments

        1. SOLR-8246.patch
          1 kB
          Jason Gerlowski
        2. SOLR-8246.patch
          2 kB
          Jason Gerlowski

          Activity

            People

            • Assignee:
              shaie Shai Erera
              Reporter:
              arafalov Alexandre Rafalovitch
            • Votes:
              0 Vote for this issue
              Watchers:
              4 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: