Solr
  1. Solr
  2. SOLR-823

${dataimporter.request.xxx} variables are not resolved

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Critical Critical
    • Resolution: Fixed
    • Affects Version/s: 1.4
    • Fix Version/s: 1.4
    • Labels:
      None

      Description

      VariableResolverImpl only steps down instances of Maps down each dot-separation.
      See lines 97-98.

      Since $

      {dataimporter.request}

      is an instance of DataImporter.RequestParams these variables are not resolved contri to the documentation found here
      http://wiki.apache.org/solr/DataImportHandler#head-520f8e527d9da55e8ed1e274e29709c8805c8eae

      Attached is one fix, with a matching test.

      1. SOLR-823.diff
        2 kB
        mck
      2. SOLR-823.patch
        3 kB
        Shalin Shekhar Mangar
      3. SOLR-823.patch
        0.9 kB
        Noble Paul

        Activity

        Hide
        Noble Paul added a comment -

        instead of changing VariableResolverImpl we can just put in a Map itself

        Show
        Noble Paul added a comment - instead of changing VariableResolverImpl we can just put in a Map itself
        Hide
        Shalin Shekhar Mangar added a comment -

        Since we are already storing the requestParams Map, no need to change VariableResolverImpl.

        Added a test over Noble's patch. I'll commit this shortly.

        Show
        Shalin Shekhar Mangar added a comment - Since we are already storing the requestParams Map, no need to change VariableResolverImpl. Added a test over Noble's patch. I'll commit this shortly.
        Hide
        Shalin Shekhar Mangar added a comment -

        Committed revision 707287.

        Thanks Mck and Noble!

        Show
        Shalin Shekhar Mangar added a comment - Committed revision 707287. Thanks Mck and Noble!
        Hide
        mck added a comment -

        works a charm now

        Show
        mck added a comment - works a charm now

          People

          • Assignee:
            Shalin Shekhar Mangar
            Reporter:
            mck
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development