Uploaded image for project: 'Solr'
  1. Solr
  2. SOLR-8198

Change ReducerStream to use StreamEqualitor instead of StreamComparator

    Details

    • Type: Improvement
    • Status: Closed
    • Priority: Minor
    • Resolution: Implemented
    • Affects Version/s: None
    • Fix Version/s: 6.0
    • Component/s: SolrJ
    • Labels:
      None

      Description

      Currently the ReducerStream uses a StreamComparator to determine whether tuples are equal. StreamEqualitors are a simplified version of a comparator in that they do not require a sort to be provided. Using the function getStreamSort we are still able to validate the incoming stream's sort and pass that on up to any parent stream which might require it.

      This will simplify the use of the ReducerStream in join scenarios where the reducer is used to find like records. Such a scenario exists with Inner/Outer JoinStream, ComplementStream, and [Outer]HashJoinStreams.

      1. SOLR-8198.patch
        12 kB
        Dennis Gove
      2. SOLR-8198.patch
        11 kB
        Dennis Gove

        Issue Links

          Activity

          Hide
          dpgove Dennis Gove added a comment -

          All tests pass.

          Show
          dpgove Dennis Gove added a comment - All tests pass.
          Hide
          dpgove Dennis Gove added a comment -

          Added a constructor accepting StreamComparator which is then converted to a StreamEqualitor. This is for backward compatibility.

          Show
          dpgove Dennis Gove added a comment - Added a constructor accepting StreamComparator which is then converted to a StreamEqualitor. This is for backward compatibility.
          Hide
          jira-bot ASF subversion and git services added a comment -

          Commit 1713204 from dpgove@apache.org in branch 'dev/trunk'
          [ https://svn.apache.org/r1713204 ]

          SOLR-8198: Change ReducerStream to use StreamEqualitor instead of StreamComparator

          Show
          jira-bot ASF subversion and git services added a comment - Commit 1713204 from dpgove@apache.org in branch 'dev/trunk' [ https://svn.apache.org/r1713204 ] SOLR-8198 : Change ReducerStream to use StreamEqualitor instead of StreamComparator

            People

            • Assignee:
              dpgove Dennis Gove
              Reporter:
              dpgove Dennis Gove
            • Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development