Solr
  1. Solr
  2. SOLR-8175

Wordbreak spellchecker throws IOOBE with Occur.MUST term

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 5.5
    • Component/s: None
    • Labels:
      None

      Description

      Using the WordBreakSolrSpellChecker, if a user queries for "+foo barbaz" and "bar baz" is a suggestion for "barbaz", Solr will throw an IndexOutOfBoundsException. As a result, a server driven by user queries might throw a certain percentage of HTTP 500 responses as users hit this.

      1. solr8175.patch
        9 kB
        Ryan Josal
      2. SOLR-8175.patch
        3 kB
        James Dyer

        Issue Links

          Activity

          Hide
          Ryan Josal added a comment -

          Uploaded solr8175.patch, which includes an updated unit test which would throw the exception without the fix. Let me know what else I can do to help.

          Show
          Ryan Josal added a comment - Uploaded solr8175.patch, which includes an updated unit test which would throw the exception without the fix. Let me know what else I can do to help.
          Hide
          Ryan Josal added a comment -

          BTW, this patch passes "ant test" and "ant precommit".

          Show
          Ryan Josal added a comment - BTW, this patch passes "ant test" and "ant precommit".
          Hide
          James Dyer added a comment -

          Ryan Josal Thanks for the bug report and the patch, especially for the unit test. Its been a while since I've committed anything, but I'll work on it tomorrow.

          Show
          James Dyer added a comment - Ryan Josal Thanks for the bug report and the patch, especially for the unit test. Its been a while since I've committed anything, but I'll work on it tomorrow.
          Hide
          Ryan Josal added a comment -

          Thanks for picking it up!

          Show
          Ryan Josal added a comment - Thanks for picking it up!
          Hide
          James Dyer added a comment -

          here is an updated patch with a slightly different unit test. It might take a little while to get this committed as I'm fighting with the test runner, precommit, etc.

          Show
          James Dyer added a comment - here is an updated patch with a slightly different unit test. It might take a little while to get this committed as I'm fighting with the test runner, precommit, etc.
          Hide
          ASF subversion and git services added a comment -

          Commit 1717492 from jdyer@apache.org in branch 'dev/trunk'
          [ https://svn.apache.org/r1717492 ]

          SOLR-8175: fix AIOOBE w/WordBreakSolrSpellChecker

          Show
          ASF subversion and git services added a comment - Commit 1717492 from jdyer@apache.org in branch 'dev/trunk' [ https://svn.apache.org/r1717492 ] SOLR-8175 : fix AIOOBE w/WordBreakSolrSpellChecker
          Hide
          ASF subversion and git services added a comment -

          Commit 1717496 from jdyer@apache.org in branch 'dev/branches/branch_5x'
          [ https://svn.apache.org/r1717496 ]

          SOLR-8175: fix AIOOBE w/WordBreakSolrSpellChecker

          Show
          ASF subversion and git services added a comment - Commit 1717496 from jdyer@apache.org in branch 'dev/branches/branch_5x' [ https://svn.apache.org/r1717496 ] SOLR-8175 : fix AIOOBE w/WordBreakSolrSpellChecker
          Hide
          James Dyer added a comment -

          Thanks, Ryan.

          Show
          James Dyer added a comment - Thanks, Ryan.

            People

            • Assignee:
              James Dyer
              Reporter:
              Ryan Josal
            • Votes:
              0 Vote for this issue
              Watchers:
              4 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development